Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Align activation job application with TS changes #375

Open
Sushisource opened this issue Dec 4, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@Sushisource
Copy link
Member

.NET currently applies jobs without reordering them (or, as I'm writing this, potentially will as a temporary workaround until we address this), but wakes up the event loop after each job.

In TS, we changed this to apply jobs to state and then run the event loop: temporalio/sdk-typescript#1488

There is a really nice test here @mjameswh added that I think all async languages should have some form of that helps us understand exactly how routines will proceed.

I'm not sure if making this change will actually have consequences to the realized .NET behavior. In any case it should probably be protected with a flag if we make it.

See temporalio/sdk-python#606 for python equivalent

@Sushisource Sushisource added the enhancement New feature or request label Dec 4, 2024
@Sushisource
Copy link
Member Author

We decided not to merge this since it requires a flag, and this change alone doesn't quite justify one. However, if #386 is done it would make sense to gate this behind the same flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant