Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waiting on update result should auto-skip time in time-skipping environments #551

Open
5 of 9 tasks
cretz opened this issue Oct 21, 2024 · 1 comment
Open
5 of 9 tasks
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Oct 21, 2024

Describe the solution you'd like

Today in time-skipping environments, we auto-skip time when waiting on workflow results. We should do the same when waiting on update results.

Per-SDK Tickets

@josh-berry
Copy link
Contributor

Per team discussion, we don't want to take this approach—this is problematic because the client is the one who says "start/stop skipping time", so there is a race between the client receiving the update result and time-skipping being stopped. During this window, we'd still be time-skipping over potentially arbitrary other events in the workflow (until the "stop time skipping" message arrives). There is also the problem that Updates run concurrently with other things in the same workflow, and it may not be appropriate to skip time for those other things.

A couple approaches here:

  1. Make the server handle starting/stopping time-skipping.
  2. Do nothing and document that users need to manually control when to skip and when not to skip. Then users can make more informed decisions that are specific to their particular scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants