Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Typed Search Attributes #336

Open
4 of 6 tasks
lorensr opened this issue Aug 31, 2023 · 1 comment
Open
4 of 6 tasks

[Feature Request] Typed Search Attributes #336

lorensr opened this issue Aug 31, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@lorensr lorensr added the enhancement New feature or request label Aug 31, 2023
@arlyon
Copy link

arlyon commented Dec 14, 2023

May I ask that you ensure that there are code samples included with major feature PRs (especially when deprecating old APIs). All my pytest tests are failing because I am updating an old project and search_attribute is deprecated, and I can't find an example of the new API anywhere (even the code samples https://github.com/temporalio/samples-python/blob/ecdfcd69b7a7894d5ed847549c0f045d41bdcb67/hello/hello_search_attributes.py#L17)

edit: found a test in the codebase for anyone on the python SDK https://github.com/cretz/temporal-sdk-python/blob/main/tests/test_client.py#L1066-L1074

edit: nevermind this feature is incompatible with my code. I specify only a single search attribute when the workflow is created, and potentially add new ones down the line once more data becomes available, meaning that all my existing workflows do not have typed search attributes in the info type for all of my data and upserting is just doesn't work, because you can update but not insert...

This code raises an exception when doing the 'insert' portion of an upsert

https://github.com/cretz/temporal-sdk-python/blob/main/temporalio/worker/_workflow_instance.py#L1287-L1294

Edit nevermind again this bug was fixed

temporalio/sdk-python@6f966c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants