-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html specs corrections 5 #5227
base: develop
Are you sure you want to change the base?
Html specs corrections 5 #5227
Conversation
d0d1438
to
504f046
Compare
c416cd2
to
d493fb2
Compare
Most of the things look OK :) A small adjustment is needed in the ImageEditor - there is width 241px set to .k-imageeditor-action-pane - this width should be increased, as in the Material and Fluent themes there is a horizontal scrollbar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the changes in the ImageEditor expected as it does not look good in some of the themes?
dac6f0f
to
619177d
Compare
As discussed at the FE & Design sync, I'll fix the width of the ImageEditor Pane for now and apply any further changes once the design has been revised. However, I'll do so in a separate PR for a better clarity: #5238 |
0be9651
to
2b69332
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay overall, I am just wondering about two things:
- If we are removing the
k-tab-on-top
class, shouldn't we remove it fromspreadsheet-jquery.tsx
as well? And if it is an obsolete class should't we delete it? - Are we okay with the difference in the ImageEditor label font weight in Fluent? I know that this is the correct checkbox position, but still.
Both classes should be present for now
The k-header class does not add any styles and seems to be obsolete
The class seems to be obsolete
As of v.16.11.0 of Kendo Angular, the toolbar items are no longer wrapped
02d1642
to
471eb0f
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking Good
targets: https://github.com/telerik/kendo-themes-private/issues/246
This PR targets the following items from the related issue:
Toolbar
Map
It seems that the class is obsolete - can we remove it?
Expansion panel / Expander
Switch
TabStrip
Removed from the spec as the class seems to be obsolete
Both classes would be present for now as the styles in the themes are attached to k-item class and some in some suites only the k-item class is present, thus replacing it would impose a breaking change
Removed from the spec as the class seems to be obsolete
CheckBox
both the class k-checked and the state :checked hold the styles. However, we should keep the class for consistency - we are adding state classes for buttons, inputs, etc- k-hover, k-focus, etc. So following the same logic, we should add k-check to the checked checkox as well .
ImageEditor
DateTimePicker, others