Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflictos de dependencias cuando la ETL usa las mismas dependencias que la libreria pero en otro número #12

Open
fgalan opened this issue Jun 13, 2022 · 1 comment

Comments

@fgalan
Copy link
Contributor

fgalan commented Jun 13, 2022

Cuando se hace el pip install de una ETL que use la libreria, si el requirements.txt de dicha ETL usa alguno de los paquetes de los que depende la libreria puede haber conflictos.

Pe. requirements usa requests==2.26.0 obtenemos este error:

The conflict is caused by:
    The user requested requests==2.26.0
    tc-etl-lib 0.1.0 depends on requests==2.21.0

Entiendo que el fix estará relacionado con esta parte del setup.py y que podría arreglarse haciendo el requirimiento más laxo (pe. "número de verseión mínimo" en vez de "número de versión exacto")

https://github.com/telefonicasc/etl-framework/blob/master/python-lib/tc_etl_lib/setup.py#L37-L41

Igual está explicando en la literatura como hacer esto de forma óptima

@fgalan
Copy link
Contributor Author

fgalan commented Dec 16, 2022

Pesco de #46 (comment) lo siguiente:

la literatura parece que concuerda: https://packaging.python.org/en/latest/discussions/install-requires-vs-requirements/

It is not considered best practice to use install_requires to pin dependencies to specific versions, or to specify sub-dependencies (i.e. dependencies of your dependencies). This is overly-restrictive, and prevents the user from gaining the benefit of dependency upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant