PERSEO_CORE_URL set in Dockerfile

[pdacostaporto]

PERSEO_CORE_URL is set in the Dockerfile. This overwrites the value of config.perseoCore from config.js with a placeholder value (http://corehost:8080) when running a container.

PERSEO_CORE_URL should not be set in the Dockerfile.

If you want to use config.perseoCore from config.js inside a container, the current workaround is to unset PERSEO_CORE_URL or reset it empty.

[AlvaroVega]

Typically, in a docker-compose.yml , you can set PERSEO_CORE_URL in environment section:

environment:
 - PERSEO_CORE_URL=http://iperseo-core-host:8080

[pdacostaporto]

Typically, in a docker-compose.yml , you can set PERSEO_CORE_URL in environment section:

environment:
 - PERSEO_CORE_URL=http://iperseo-core-host:8080

That's not an option. I need to use the value on config.js.

The workaround in docker-compose would be to set PERSEO_CORE_URL empty. Also works for k8s.

[AlvaroVega]

Maybe you can contribute with whatever you need in a environment variable and adding it to: https://github.com/telefonicaid/perseo-fe/blob/master/bin/perseo#L170-L173

[pdacostaporto]

Maybe you can contribute with whatever you need in a environment variable and adding it to: https://github.com/telefonicaid/perseo-fe/blob/master/bin/perseo#L170-L173

Why not remove it from the Dockerfile? Looks like it's just setting a placeholder value. I don't see what's the point of setting it there.

[fgalan]

PR #811, already merged

@pdacostaporto can this issue be closed?