Bump gson from 2.6.2 to 2.10.1 in /cygnus-common #2168

dependabot · 2022-05-20T20:49:58Z

Bumps gson from 2.6.2 to 2.10.1.

Release notes

Gson 2.8.9

Make OSGi bundle's dependency on sun.misc optional (#1993).

Deprecate Gson.excluder() exposing internal Excluder class (#1986).

Prevent Java deserialization of internal classes (#1991).

Improve number strategy implementation (#1987).

Fix LongSerializationPolicy null handling being inconsistent with Gson (#1990).

Support arbitrary Number implementation for Object and Number deserialization (#1290).

Bump proguard-maven-plugin from 2.4.0 to 2.5.1 (#1980).

Don't exclude static local classes (#1969).

Fix RuntimeTypeAdapterFactory depending on internal Streams class (#1959).

Improve Maven build (#1964).

Make dependency on java.sql optional (#1707).

Gson 2.8.8

Fixed issue with recursive types (#1390).

Better behaviour with Java 9+ and Unsafe if there is a security manager (#1712).

EnumTypeAdapter now works better when ProGuard has obfuscated enum fields (#1495).

Changelog

Sourced from gson's changelog.

Version 2.8.9

Make OSGi bundle's dependency on sun.misc optional (#1993).

Deprecate Gson.excluder() exposing internal Excluder class (#1986).

Prevent Java deserialization of internal classes (#1991).

Improve number strategy implementation (#1987).

Fix LongSerializationPolicy null handling being inconsistent with Gson (#1990).

Support arbitrary Number implementation for Object and Number deserialization (#1290).

Bump proguard-maven-plugin from 2.4.0 to 2.5.1 (#1980).

Don't exclude static local classes (#1969).

Fix RuntimeTypeAdapterFactory depending on internal Streams class (#1959).

Improve Maven build (#1964).

Make dependency on java.sql optional (#1707).

Version 2.8.8

Fixed issue with recursive types (#1390).

Better behaviour with Java 9+ and Unsafe if there is a security manager (#1712).

EnumTypeAdapter now works better when ProGuard has obfuscated enum fields (#1495).

Version 2.8.7

Fixed ISO8601UtilsTest failing on systems with UTC+X.

Improved javadoc for JsonStreamParser.

Updated proguard.cfg (#1693).

Fixed IllegalStateException in JsonTreeWriter (#1592).

Added JsonArray.isEmpty() (#1640).

Added new test cases (#1638).

Fixed OSGi metadata generation to work on JavaSE < 9 (#1603).

Version 2.8.6

2019-10-04 GitHub Diff

Added static methods JsonParser.parseString and JsonParser.parseReader and deprecated instance method JsonParser.parse

Java 9 module-info support

Version 2.8.5

2018-05-21 GitHub Diff

Print Gson version while throwing AssertionError and IllegalArgumentException

Moved utils.VersionUtils class to internal.JavaVersion. This is a potential backward incompatible change from 2.8.4

Fixed issue google/gson#1310 by supporting Debian Java 9

Version 2.8.4

2018-05-01 GitHub Diff

Added a new FieldNamingPolicy, LOWER_CASE_WITH_DOTS that mapps JSON name someFieldName to some.field.name

Fixed issue google/gson#1305 by removing compile/runtime dependency on sun.misc.Unsafe

Version 2.8.3

2018-04-27 GitHub Diff

Added a new API, GsonBuilder.newBuilder() that clones the current builder

Preserving DateFormatter behavior on JDK 9

... (truncated)

Commits

6a368d8 [maven-release-plugin] prepare release gson-parent-2.8.9
ba96d53 Fix missing bounds checks for JsonTreeReader.getPath() (#2001)
ca1df7f #1981: Optional OSGi bundle's dependency on sun.misc package (#1993)
c54caf3 Deprecate Gson.excluder() exposing internal Excluder class (#1986)
e6fae59 Prevent Java deserialization of internal classes (#1991)
bda2e3d Improve number strategy implementation (#1987)
cd748df Fix LongSerializationPolicy null handling being inconsistent with Gson (#1990)
fe30b85 Support arbitrary Number implementation for Object and Number deserialization...
1cc1627 Fix incorrect feature request template label (#1982)
7b9a283 Bump bnd-maven-plugin from 5.3.0 to 6.0.0 (#1985)
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [gson](https://github.com/google/gson) from 2.6.2 to 2.8.9. - [Release notes](https://github.com/google/gson/releases) - [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md) - [Commits](google/gson@gson-parent-2.6.2...gson-parent-2.8.9) --- updated-dependencies: - dependency-name: com.google.code.gson:gson dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>

fgalan · 2022-05-23T08:24:37Z

It seems some test are failing in this PR:

Tests in error: 
  testNameMappingsPatternsCompiled(com.telefonica.iot.cygnus.containers.NameMappingsTest): com.google.gson.stream.MalformedJsonException: Invalid escape sequence at line 1 column 341 path $.serviceMappings[0].servicePathMappings[0].entityMappings[0].originalEntityId

Tests run: 780, Failures: 0, Errors: 1, Skipped: 0

Thus it would require some extra work and cannot be directly merged

…code.gson-gson-2.8.9

fgalan

~~LGTM~~

fgalan · 2023-01-16T09:33:26Z

Cannot be merged... unit tests are broken.

AlvaroVega · 2023-01-18T11:22:01Z

"originalEntityId": "Room\.(\d*)","

It seems some test are failing in this PR:

Tests in error: 
  testNameMappingsPatternsCompiled(com.telefonica.iot.cygnus.containers.NameMappingsTest): com.google.gson.stream.MalformedJsonException: Invalid escape sequence at line 1 column 341 path $.serviceMappings[0].servicePathMappings[0].entityMappings[0].originalEntityId

Tests run: 780, Failures: 0, Errors: 1, Skipped: 0

Thus it would require some extra work and cannot be directly merged

The test is in error is using this namemapping:

fiware-cygnus/cygnus-ngsi/src/test/java/com/telefonica/iot/cygnus/containers/NameMappingsTest.java

Lines 240 to 270 in c7d6f13

    
           private final String nameMappingsRegex = ""  
        
                   + "{" 
        
                   + "   \"serviceMappings\": [" 
        
                   + "      {" 
        
                   + "         \"originalService\": \".*\"," 
        
                   + "         \"newService\": \"new_default\"," 
        
                   + "         \"servicePathMappings\": [" 
        
                   + "            {" 
        
                   + "               \"originalServicePath\": \"/.*\"," 
        
                   + "               \"newServicePath\": \"/new_default\"," 
        
                   + "               \"entityMappings\": [" 
        
                   + "                  {" 
        
                   + "                     \"originalEntityId\": \"Room\\.(\\d*)\"," 
        
                   + "                     \"originalEntityType\": \"Room\"," 
        
                   + "                     \"newEntityId\": \"new_Room1\"," 
        
                   + "                     \"newEntityType\": \"new_Room\"," 
        
                   + "                     \"attributeMappings\": [" 
        
                   + "                        {" 
        
                   + "                           \"originalAttributeName\": \"temp*\"," 
        
                   + "                           \"originalAttributeType\": \"cent*\"," 
        
                   + "                           \"newAttributeName\": \"new_temperature\"," 
        
                   + "                           \"newAttributeType\": \"new_centigrade\"" 
        
                   + "                        }" 
        
                   + "                     ]" 
        
                   + "                  }" 
        
                   + "               ]" 
        
                   + "            }" 
        
                   + "         ]" 
        
                   + "      }" 
        
                   + "   ]" 
        
                   + "}";

And concretly this regex:
{
"originalEntityId": "Room.(d*)"
}

fgalan · 2023-01-18T15:59:15Z

Somehow something in the JSON field doesn't like to the new version of gson package...

…code.gson-gson-2.8.9

AlvaroVega · 2023-09-14T09:25:51Z

I guess we can simplify tests by Room\.(\d*) to Room*

fgalan · 2023-09-14T09:37:18Z

I guess we can simplify tests by Room\.(\d*) to Room*

Agree.

AlvaroVega

LGTM

fgalan

LGTM

dependabot bot added the dependencies Pull requests that update a dependency file label May 20, 2022

ADD entry to CNR

e1b20dc

Merge branch 'master' into dependabot/maven/cygnus-common/com.google.…

18f0175

…code.gson-gson-2.8.9

fgalan approved these changes Jan 16, 2023

View reviewed changes

Update pom.xml

14e6f2d

AlvaroVega changed the title ~~Bump gson from 2.6.2 to 2.8.9 in /cygnus-common~~ Bump gson from 2.6.2 to 2.10.1 in /cygnus-common Jan 18, 2023

Update CHANGES_NEXT_RELEASE

7b5a29b

AlvaroVega and others added 6 commits January 19, 2023 12:29

Merge branch 'master' into dependabot/maven/cygnus-common/com.google.…

ad4b9c7

…code.gson-gson-2.8.9

Merge branch 'master' into dependabot/maven/cygnus-common/com.google.…

61e6f27

…code.gson-gson-2.8.9

FIX CHANGES_NEXT_RELEASE

6d7b51f

Merge branch 'master' into dependabot/maven/cygnus-common/com.google.…

7061ae9

…code.gson-gson-2.8.9

Merge branch 'master' into dependabot/maven/cygnus-common/com.google.…

07ec3f5

…code.gson-gson-2.8.9

Update NameMappingsTest.java

b0d293d

AlvaroVega approved these changes Sep 14, 2023

View reviewed changes

fgalan approved these changes Sep 14, 2023

View reviewed changes

fgalan merged commit 11e4b85 into master Sep 14, 2023

fgalan deleted the dependabot/maven/cygnus-common/com.google.code.gson-gson-2.8.9 branch September 14, 2023 10:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump gson from 2.6.2 to 2.10.1 in /cygnus-common #2168

Bump gson from 2.6.2 to 2.10.1 in /cygnus-common #2168

dependabot bot commented on behalf of github May 20, 2022 •

edited by AlvaroVega

Loading

fgalan commented May 23, 2022

fgalan left a comment •

edited

Loading

fgalan commented Jan 16, 2023

AlvaroVega commented Jan 18, 2023 •

edited

Loading

fgalan commented Jan 18, 2023

AlvaroVega commented Sep 14, 2023

fgalan commented Sep 14, 2023

AlvaroVega left a comment

fgalan left a comment

Bump gson from 2.6.2 to 2.10.1 in /cygnus-common #2168

Bump gson from 2.6.2 to 2.10.1 in /cygnus-common #2168

Conversation

dependabot bot commented on behalf of github May 20, 2022 • edited by AlvaroVega Loading

Gson 2.8.9

Gson 2.8.8

Version 2.8.9

Version 2.8.8

Version 2.8.7

Version 2.8.6

Version 2.8.5

Version 2.8.4

Version 2.8.3

fgalan commented May 23, 2022

fgalan left a comment • edited Loading

Choose a reason for hiding this comment

fgalan commented Jan 16, 2023

AlvaroVega commented Jan 18, 2023 • edited Loading

fgalan commented Jan 18, 2023

AlvaroVega commented Sep 14, 2023

fgalan commented Sep 14, 2023

AlvaroVega left a comment

Choose a reason for hiding this comment

fgalan left a comment

Choose a reason for hiding this comment

dependabot bot commented on behalf of github May 20, 2022 •

edited by AlvaroVega

Loading

fgalan left a comment •

edited

Loading

AlvaroVega commented Jan 18, 2023 •

edited

Loading