Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arcgis sink uniqueId is not updated when customNotification is modified #2349

Closed
AlvaroVega opened this issue Mar 1, 2024 · 4 comments
Closed

Comments

@AlvaroVega
Copy link
Member

AlvaroVega commented Mar 1, 2024

When a custom notification (https://github.com/telefonicaid/fiware-orion/blob/master/doc/manuals/orion-api.md#custom-notifications )like:

{
  "url": "http://host-cygnus/notify",
  "ngsi": {
    "type": "fiwareid"
  },
  "headers": {
    "fiware-service": "base",
    "fiware-servicepath": "/path/FeatureServer/0"
  }
}

is modified to

{
  "url": "http://host-cygnus/notify",
  "ngsi": {
    "type": "name"
  },
  "headers": {
    "fiware-service": "base",
    "fiware-servicepath": "/path/FeatureServer/0"
  }
}

arcgis sink is using new value for type (used by uniqueFiledId)

@AlvaroVega
Copy link
Member Author

related : #2347

@AlvaroVega
Copy link
Member Author

AlvaroVega commented Mar 1, 2024

if (isNewFeatureTable) {
LOGGER.debug("[" + this.getName() + "] Created new backend for " + featureTableUrl
+ " with uniqueField: " + aggregation.getUniqueField());
featureTable.setUniqueField(aggregation.getUniqueField());
}

Maybe we should force to set uniqueId from aggregation always

@fgalan
Copy link
Member

fgalan commented Mar 1, 2024

PR #2350

@danielvillalbamota
Copy link
Collaborator

PR #2350

This solves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants