Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed duplicate step ID from _reusable-package-testpypi.yml. #23

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Aug 28, 2024

Proposed changes

This removes a duplicate step ID from a reusable workflow and adds a pre-commit hook to catch these issues before they are committed in the future.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have created (or updated) an Issue to track the status of this update/change and updated the link in this PR description (see above in the Proposed changes section) using the wording Addresses #<issue_number>
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

Also added a pre-commit hook to check the workflow files.
@nfelt14 nfelt14 requested a review from a team as a code owner August 28, 2024 15:22
@nfelt14 nfelt14 enabled auto-merge (squash) August 28, 2024 15:22
@nfelt14 nfelt14 disabled auto-merge August 28, 2024 15:22
@nfelt14 nfelt14 enabled auto-merge (squash) August 28, 2024 15:22
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f7dc8db) to head (b4a62f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          189       189           
  Branches        39        39           
=========================================
  Hits           189       189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfelt14 nfelt14 disabled auto-merge August 28, 2024 15:56
@nfelt14 nfelt14 enabled auto-merge (squash) August 28, 2024 15:56
@nfelt14 nfelt14 merged commit 5869bb6 into main Aug 28, 2024
31 checks passed
@nfelt14 nfelt14 deleted the nfelt14/bugfix/fix-testpypi-workflow branch August 28, 2024 15:57
Copy link

github-actions bot commented Aug 28, 2024

Test Results (ubuntu)

path passed subtotal
tests/test_bump_version_in_files.py 5 5
tests/test_create_unique_testpypi_version.py 7 7
tests/test_find_unreleased_changelog_items.py 3 3
tests/test_update_development_dependencies.py 13 13
TOTAL 28 28

Link to workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant