Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beef up tests #9

Open
ZNielsen opened this issue Sep 28, 2019 · 5 comments
Open

Beef up tests #9

ZNielsen opened this issue Sep 28, 2019 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Good issues to work on for Hacktoberfest!

Comments

@ZNielsen
Copy link
Collaborator

ZNielsen commented Sep 28, 2019 •
edited
Loading

Currently, the tests only exercise the core converter function, but there's logic to format the input before that function is called that remains untouched by the tests.

edit
Thanks to @Baev1, we have much better test coverage on the formatting logic. This ticket is now open for anyone to add any tests.
@ZNielsen ZNielsen added enhancement New feature or request good first issue Good for newcomers hacktoberfest Good issues to work on for Hacktoberfest! labels Sep 28, 2019
@CalliEve
Copy link
Contributor

CalliEve commented Oct 1, 2019

Hi! I would like to work on this if that's alright ^^

@ZNielsen
Copy link
Collaborator Author

ZNielsen commented Oct 1, 2019

Of course! I'll assign it to you and you can jump right in.

@CalliEve
Copy link
Contributor

CalliEve commented Oct 1, 2019

Would it be okay for me to split some parts of the main function into separate functions for better/easier testing? mainly the "Sort out the optional indexed argument" and "Convert input number to base 10" sections

@ZNielsen
Copy link
Collaborator Author

ZNielsen commented Oct 1, 2019

Absolutely. Those probably should have been separate functions to begin with.

@CalliEve CalliEve mentioned this issue Oct 2, 2019
Merged
@ZNielsen ZNielsen closed this as completed Oct 2, 2019
@ZNielsen ZNielsen reopened this Oct 2, 2019
@ZNielsen
Copy link
Collaborator Author

ZNielsen commented Oct 2, 2019

Realized there could always be more tests. Leaving this open in case anyone else wants to come along and add some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Good issues to work on for Hacktoberfest!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZNielsen @CalliEve