Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Tests won't run without admin privileges on Windows and are very flaky #3

Open
nfelt14 opened this issue Sep 6, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@nfelt14
Copy link
Collaborator

nfelt14 commented Sep 6, 2024

Description of the bug

I am unable to run the unit tests without admin privileges on Windows. The tests should be able to run without enhanced privileges.

Steps To Reproduce

  1. Run unit tests in cmd prompt
  2. notice they all have errors

Environment Information

No response

Additional Information

No response

@nfelt14 nfelt14 added the bug Something isn't working label Sep 6, 2024
@u625355
Copy link
Contributor

u625355 commented Sep 6, 2024

I was able to run unit tests after activating virtual environment from command prompt without admin privileges on Windows.
image

@nfelt14
Copy link
Collaborator Author

nfelt14 commented Sep 6, 2024

I was not, we should probably figure out a way to do this that doesn't require psutil.

@u625355
Copy link
Contributor

u625355 commented Sep 6, 2024

May be we can use os and socket packages instead of psutil.

@nfelt14
Copy link
Collaborator Author

nfelt14 commented Sep 6, 2024

We should just be able to run it within the existing python process as a background thread.

@nfelt14
Copy link
Collaborator Author

nfelt14 commented Sep 6, 2024

The tests also seem to run extremely slowly

@u625355 u625355 self-assigned this Sep 12, 2024
@nfelt14 nfelt14 changed the title [BUG]: Tests won't run without admin privileges on Windows [BUG]: Tests won't run without admin privileges on Windows and are very flaky Sep 12, 2024
@nfelt14
Copy link
Collaborator Author

nfelt14 commented Sep 12, 2024

The tests also often have false failures when run during GitHub Actions.

@nfelt14
Copy link
Collaborator Author

nfelt14 commented Nov 11, 2024

@pradhanfortive this keeps happening in CI. The tests fail repeatedly due to the flakiness within them. This needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants