Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.56.x] Upgrade golang.org/x/crypto to 0.31.0 #8443

Open
wants to merge 1 commit into
base: release-v0.56.x
Choose a base branch
from
Open

[release-v0.56.x] Upgrade golang.org/x/crypto to 0.31.0 #8443

wants to merge 1 commit into from

Conversation

vdemeester
Copy link
Member

Changes

Fixing a critical CVE.
See GHSA-v778-237x-gjrc

Signed-off-by: Vincent Demeester [email protected]

/kind security

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Upgrade golang.org/x/crypto to 0.31.0 to fix CVE-2024-45337

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/security Categorizes issue or PR as related to a security issue labels Dec 17, 2024
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 17, 2024
@vdemeester
Copy link
Member Author

/assign @afrittoli

@afrittoli
Copy link
Member

It looks like we're missing integration tests. I see two options:

  • Backport the workflows
  • Restore the prow jobs for some branches only

@vdemeester wdyt?

@vdemeester
Copy link
Member Author

@afrittoli ah that's good point. I think we should backport the workflows indeed.

@vdemeester
Upgrade golang.org/x/crypto to 0.31.0
a1147be 
Fixing a critical CVE.
See GHSA-v778-237x-gjrc

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from afrittoli after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member Author

@afrittoli ah well, it's not "just" a backport, we need to change the branch targeted 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom Awaiting requested review from dibyom

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@afrittoli afrittoli

Labels
kind/security Categorizes issue or PR as related to a security issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vdemeester @afrittoli @tekton-robot