From 3d9e3e94167157268dabbb4388659cfab5f19491 Mon Sep 17 00:00:00 2001 From: Samarth Maganahalli Date: Sat, 29 Jun 2024 13:41:53 +0530 Subject: [PATCH] address comments --- pkg/reconciler/pipelinerun/pipelinerun.go | 4 ++-- pkg/reconciler/pipelinerun/pipelinerun_test.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/reconciler/pipelinerun/pipelinerun.go b/pkg/reconciler/pipelinerun/pipelinerun.go index 3ca088433e7..8a2c8ea4376 100644 --- a/pkg/reconciler/pipelinerun/pipelinerun.go +++ b/pkg/reconciler/pipelinerun/pipelinerun.go @@ -489,8 +489,8 @@ func (c *Reconciler) reconcile(ctx context.Context, pr *v1.PipelineRun, getPipel if err := resources.ValidateRequiredParametersProvided(&pipelineSpec.Params, &pr.Spec.Params); err != nil { // This Run has failed, so we need to mark it as failed and stop reconciling it pr.Status.MarkFailed(v1.PipelineRunReasonParameterMissing.String(), - "PipelineRun %s/%s is missing some parameters required by Pipeline %s: %s", - pr.Namespace, pr.Name, pipelineMeta.Name, err) + "PipelineRun %s/%s is missing some parameters required by Pipeline %s/%s: %s", + pr.Namespace, pr.Name, pr.Namespace, pipelineMeta.Name, err) return controller.NewPermanentError(err) } diff --git a/pkg/reconciler/pipelinerun/pipelinerun_test.go b/pkg/reconciler/pipelinerun/pipelinerun_test.go index 75450dba190..ff523ddf6d1 100644 --- a/pkg/reconciler/pipelinerun/pipelinerun_test.go +++ b/pkg/reconciler/pipelinerun/pipelinerun_test.go @@ -969,7 +969,7 @@ spec: permanentError: true, wantEvents: []string{ "Normal Started", - "Warning Failed [User error] PipelineRun foo/pipelinerun-missing-params-1 is missing some parameters required by Pipeline a-pipeline-with-array-params: pipelineRun missing parameters: [some-param]", + "Warning Failed [User error] PipelineRun foo/pipelinerun-missing-params-1 is missing some parameters required by Pipeline foo/a-pipeline-with-array-params: pipelineRun missing parameters: [some-param]", }, }, { name: "invalid-pipeline-run-missing-params-with-spec-shd-stop-reconciling", @@ -991,7 +991,7 @@ spec: permanentError: true, wantEvents: []string{ "Normal Started", - "Warning Failed [User error] PipelineRun foo/pipelinerun-missing-params-2 is missing some parameters required by Pipeline pipelinerun-missing-params-2: pipelineRun missing parameters: [some-param]", + "Warning Failed [User error] PipelineRun foo/pipelinerun-missing-params-2 is missing some parameters required by Pipeline foo/pipelinerun-missing-params-2: pipelineRun missing parameters: [some-param]", }, }, { name: "invalid-pipeline-with-invalid-dag-graph",