Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Keep all the hard coded text at one place so that it can be found and updated easily #319

Open
vinamra28 opened this issue Sep 6, 2021 · 3 comments
Open

UI: Keep all the hard coded text at one place so that it can be found and updated easily #319

vinamra28 opened this issue Sep 6, 2021 · 3 comments
Labels
kind/question Issues or PRs that are questions around the project or a particular feature lifecycle/frozen

Comments

@vinamra28
Copy link
Member

All the hard coded text is kept within the code as of now so it becomes difficult for contributors to find the place and add new things or fix things.

Suggestion

We can place all the hard coded text at one place so that if there are any modifications it can be made easily. Also if we are going to support i18n in future then also it will be easy to replace text.

/kind question
/cc @tektoncd/hub-collaborators
@tekton-robot tekton-robot added the kind/question Issues or PRs that are questions around the project or a particular feature label Sep 6, 2021
@vinamra28 vinamra28 changed the title Keep all the hard coded text at one place so that it can be found and updated easily UI: Keep all the hard coded text at one place so that it can be found and updated easily Sep 6, 2021
@vinamra28
Copy link
Member Author

example: https://github.com/tektoncd/hub/pull/316/files#diff-b1c62177c9337a3ebcdc9eec15dcd5cad3228bd118ebf555ee7dce11226ebb1aR104 this can be moved to a common place maybe strings.ts 🤔

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@vinamra28
Copy link
Member Author

/remove-lifecycle stale
/lifecycle frozen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/question Issues or PRs that are questions around the project or a particular feature lifecycle/frozen
Projects
Tekton Community Roadmap
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vinamra28 @tekton-robot