Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Adds Instructions to add Tasks or Pipelines #316

Closed
wants to merge 1 commit into from
Closed

UI: Adds Instructions to add Tasks or Pipelines #316

wants to merge 1 commit into from

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Aug 31, 2021 •
edited
Loading

This patch adds a dropdown and onclick it opens a modal
which shows instructions to add a resource or catalog to Hub

Screenshot from 2021-09-24 13-31-33

Screenshot from 2021-09-29 15-28-28

Screenshot from 2021-09-29 18-08-04

Closes: #239

Signed-off-by: Shiv Verma [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

See the contribution guide for more details.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pratap0007
You can assign the PR to them by writing /assign @pratap0007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2021
@pratap0007 pratap0007 force-pushed the add-tasks-pipelines branch 4 times, most recently from 3a6c833 to 5a4a0ae Compare September 8, 2021 07:43
piyush-garg
piyush-garg reviewed Sep 9, 2021
View reviewed changes
ui/src/containers/Header/index.tsx Outdated
</TextListItem>
</TextList>
<Text component={TextVariants.blockquote}>
Note: Added tasks or pipelines would be available on the Hub within 30 minutes once
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newly added resource

@pratap0007 pratap0007 force-pushed the add-tasks-pipelines branch 2 times, most recently from 75d0fc9 to 77d9b3d Compare September 15, 2021 04:52
@vinamra28
Copy link
Member

@pratap0007 by any chance can we reduce the space between the Login button and contribute dropdown?
image

@pratap0007
Copy link
Contributor Author

@pratap0007 by any chance can we reduce the space between the Login button and contribute dropdown?
image

yes, will give a try

@pratap0007 pratap0007 force-pushed the add-tasks-pipelines branch 2 times, most recently from 71654f7 to 461e604 Compare September 24, 2021 08:29
vinamra28
vinamra28 reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021
@pratap0007 pratap0007 force-pushed the add-tasks-pipelines branch 2 times, most recently from 3848ca5 to 0e891b7 Compare September 29, 2021 12:41
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2021
@pratap0007 pratap0007 force-pushed the add-tasks-pipelines branch from 0e891b7 to 975a768 Compare October 6, 2021 10:49
@pratap0007
Copy link
Contributor Author

/test pull-tekton-hub-unit-tests

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2021
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2021
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2022
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2022
@pratap0007
Copy link
Contributor Author

/test pull-tekton-hub-unit-tests

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/stale needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 17, 2022
@pratap0007
Adds Instructions to add Tasks or Pipelines
b54ff66 
This patch adds an icon and onclick it opens a modal
which shows instructions to add tasks or pipelines to Hub

Signed-off-by: Shiv Verma <[email protected]>
@pratap0007 pratap0007 force-pushed the add-tasks-pipelines branch from f433b20 to b54ff66 Compare May 6, 2022 05:19
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2022
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2022
@tekton-robot
Copy link

@pratap0007: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pratap0007
Copy link
Contributor Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2022
@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sm43 sm43 sm43 left review comments

@PuneetPunamiya PuneetPunamiya PuneetPunamiya left review comments

@vinamra28 vinamra28 vinamra28 left review comments

@piyush-garg piyush-garg piyush-garg left review comments

@sthaha sthaha Awaiting requested review from sthaha

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add instructions for adding items
6 participants
@pratap0007 @tekton-robot @vinamra28 @piyush-garg @PuneetPunamiya @sm43