From 41f0a5e80ca98892a3161d4cc096e96951bba67b Mon Sep 17 00:00:00 2001 From: nicoleooi Date: Fri, 20 Nov 2020 15:17:37 -0500 Subject: [PATCH 1/5] started changes description document --- qa327_test/changes_description.md | 37 +++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 qa327_test/changes_description.md diff --git a/qa327_test/changes_description.md b/qa327_test/changes_description.md new file mode 100644 index 0000000..7b0d412 --- /dev/null +++ b/qa327_test/changes_description.md @@ -0,0 +1,37 @@ +# Description of Changes +The template files provided had to be altered to conduct front-end unit testing. The following table summarizes the changes made: + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
FileChanges MadePurpose
base.html
index.html
login.html
register.html
From 1eb84fd58ae9e08922a47b872609a6cf405db663 Mon Sep 17 00:00:00 2001 From: nicoleooi Date: Fri, 20 Nov 2020 15:20:24 -0500 Subject: [PATCH 2/5] added to changes doc --- qa327_test/changes_description.md | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/qa327_test/changes_description.md b/qa327_test/changes_description.md index 7b0d412..6c35d55 100644 --- a/qa327_test/changes_description.md +++ b/qa327_test/changes_description.md @@ -12,7 +12,7 @@ The template files provided had to be altered to conduct front-end unit testing. base.html - + Allows templates to flash error messages for invalid formatting, wrong password and user combinations, and other requirements. @@ -33,5 +33,17 @@ The template files provided had to be altered to conduct front-end unit testing. + + backend.py + + + + + + frontend.py + + + + From 2661d859bb161156a1ca0de016cf9a8bfdf773cb Mon Sep 17 00:00:00 2001 From: Joshua Neizer Date: Fri, 20 Nov 2020 17:01:31 -0500 Subject: [PATCH 3/5] Completed rough draft of changes_description.md --- qa327_test/changes_description.md | 29 ++++++++--------------------- 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/qa327_test/changes_description.md b/qa327_test/changes_description.md index 6c35d55..d9155a7 100644 --- a/qa327_test/changes_description.md +++ b/qa327_test/changes_description.md @@ -11,39 +11,26 @@ The template files provided had to be altered to conduct front-end unit testing. base.html - - Allows templates to flash error messages for invalid formatting, wrong password and user combinations, and other requirements. + Added a html flash template that allows messages from different pages to flash said message to the current page. All pages automatically inherit this template to allow them to receive a flashed messaged. + Allows templates to flash error messages for invalid formatting, wrong password and user combinations, and other requirements in a simple and clean manner. index.html - - + Added in fields for tickets, Selling tickets, Updating tickets and buy tickets + Provides a template for all tickets to be seen, purchased, updated and sold by the user on the main page. login.html - - + Changed line 5 to have an id of 'login_message' and have a static message of "Please Login". + Since we changed all messaging between pages to use the flash function from the flask library, we decided to leave the login message static. Therefore, the error messages are flashed to the html elements that are inherited from base.html, rather than to the 'login_message' id. Also, the id name was changed to differentiate it from the other message ids that typically display error messages. register.html - - + Removed required attributes from the the input fields + The required attributes conflicted with the R2 requirements testing. In particular, it made it difficult to check if our frontend.py file would error check an empty string inputs as the required field would not let an empty field be submitted. Therefore, they were removed to validate our error checking. - - - backend.py - - - - - - frontend.py - - - - From b6c66a5578fe74cf5c89c8707c8f5c83cefc4892 Mon Sep 17 00:00:00 2001 From: Joshua Neizer Date: Fri, 20 Nov 2020 17:02:08 -0500 Subject: [PATCH 4/5] removed extra signle quotation mark --- qa327/templates/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qa327/templates/index.html b/qa327/templates/index.html index b480ee5..edafb57 100644 --- a/qa327/templates/index.html +++ b/qa327/templates/index.html @@ -19,7 +19,7 @@

Here are all available tickets

{% for ticket in tickets %} -
+

{{ ticket.name }} {{ ticket.price }} From 684cb6e6655a81130aea64b9be1bf910d976c220 Mon Sep 17 00:00:00 2001 From: Joshua Neizer Date: Fri, 20 Nov 2020 17:09:57 -0500 Subject: [PATCH 5/5] Fixed typo and adjusted phrasing to be more clear --- qa327_test/changes_description.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qa327_test/changes_description.md b/qa327_test/changes_description.md index d9155a7..413a895 100644 --- a/qa327_test/changes_description.md +++ b/qa327_test/changes_description.md @@ -11,13 +11,13 @@ The template files provided had to be altered to conduct front-end unit testing. base.html - Added a html flash template that allows messages from different pages to flash said message to the current page. All pages automatically inherit this template to allow them to receive a flashed messaged. + Added a html flash template that allows messages from different pages to flash said message to the current page. All pages will now automatically inherit this template. Allows templates to flash error messages for invalid formatting, wrong password and user combinations, and other requirements in a simple and clean manner. index.html - Added in fields for tickets, Selling tickets, Updating tickets and buy tickets + Added in HTML code for tickets, Selling tickets, Updating tickets and buy tickets Provides a template for all tickets to be seen, purchased, updated and sold by the user on the main page. @@ -29,8 +29,8 @@ The template files provided had to be altered to conduct front-end unit testing. register.html - Removed required attributes from the the input fields - The required attributes conflicted with the R2 requirements testing. In particular, it made it difficult to check if our frontend.py file would error check an empty string inputs as the required field would not let an empty field be submitted. Therefore, they were removed to validate our error checking. + Removed required attributes from the input fields + The required attributes conflicted with the R2 requirements testing. In particular, it made it difficult to check if our frontend.py file would error check an empty string inputs as the required attribute would not let an empty field be submitted. Therefore, they were removed to validate our error checking.