From 6f030f1ec7584e6159d10708243f787bf3256341 Mon Sep 17 00:00:00 2001
From: Stephen Hand <steveh@techmatters.org>
Date: Fri, 7 Jun 2024 08:04:26 +0100
Subject: [PATCH] Log oout conversation state on post survey listener -
 serialise concurrent logic for conversations

---
 .../channelCaptureHandlers.private.ts         | 80 +++++++++++--------
 1 file changed, 45 insertions(+), 35 deletions(-)

diff --git a/functions/channelCapture/channelCaptureHandlers.private.ts b/functions/channelCapture/channelCaptureHandlers.private.ts
index 64876bae..0366d427 100644
--- a/functions/channelCapture/channelCaptureHandlers.private.ts
+++ b/functions/channelCapture/channelCaptureHandlers.private.ts
@@ -434,56 +434,66 @@ export const handleChannelCapture = async (
   const parsedAdditionalControlTaskAttributes = additionControlTaskAttributes
     ? JSON.parse(additionControlTaskAttributes)
     : {};
-
-  const [, , controlTask] = await Promise.all([
-    // Remove the studio trigger webhooks to prevent this channel to trigger subsequent Studio flows executions
-    !conversationSid &&
+  let controlTask: TaskInstance;
+  if (conversationSid) {
+    const conversationContext = await context
+      .getTwilioClient()
+      .conversations.conversations(conversationSid);
+    console.log('conversation state:', (await conversationContext.fetch()).state);
+    // Create control task to prevent channel going stale
+    controlTask = await context
+      .getTwilioClient()
+      .taskrouter.workspaces(context.TWILIO_WORKSPACE_SID)
+      .tasks.create({
+        workflowSid: context.SURVEY_WORKFLOW_SID,
+        taskChannel: 'survey',
+        attributes: JSON.stringify({
+          isChatCaptureControl: true,
+          conversationSid,
+          ...parsedAdditionalControlTaskAttributes,
+        }),
+        timeout: controlTaskTTL || 45600, // 720 minutes or 12 hours
+      });
+    const webhooks = await conversationContext.webhooks.list();
+    for (const webhook of webhooks) {
+      if (webhook.target === 'studio') {
+        // eslint-disable-next-line no-await-in-loop
+        await webhook.remove();
+      }
+    }
+  } else {
+    [, controlTask] = await Promise.all([
+      // Remove the studio trigger webhooks to prevent this channel to trigger subsequent Studio flows executions
       context
         .getTwilioClient()
         .chat.services(context.CHAT_SERVICE_SID)
         .channels(channelSid)
         .webhooks.list()
-        .then((channelWebhooks) =>
-          channelWebhooks.map(async (w) => {
+        .then((webhooks) =>
+          webhooks.map(async (w) => {
             if (w.type === 'studio') {
               await w.remove();
             }
           }),
         ),
 
-    /*
-     * Doing the "same" as above but for Conversations. Differences to the Studio Webhook in this case:
-     * - It's NOT found under the channel webhooks, but under the conversation webhooks
-     * - It uses the property 'target' instead of 'type'
-     */
-    conversationSid &&
+      // Create control task to prevent channel going stale
       context
         .getTwilioClient()
-        .conversations.conversations(conversationSid)
-        .webhooks.list()
-        .then((channelWebhooks) =>
-          channelWebhooks.map(async (w) => {
-            if (w.target === 'studio') {
-              await w.remove();
-            }
+        .taskrouter.workspaces(context.TWILIO_WORKSPACE_SID)
+        .tasks.create({
+          workflowSid: context.SURVEY_WORKFLOW_SID,
+          taskChannel: 'survey',
+          attributes: JSON.stringify({
+            isChatCaptureControl: true,
+            channelSid,
+            conversationSid,
+            ...parsedAdditionalControlTaskAttributes,
           }),
-        ),
-
-    // Create control task to prevent channel going stale
-    context
-      .getTwilioClient()
-      .taskrouter.workspaces(context.TWILIO_WORKSPACE_SID)
-      .tasks.create({
-        workflowSid: context.SURVEY_WORKFLOW_SID,
-        taskChannel: 'survey',
-        attributes: JSON.stringify({
-          isChatCaptureControl: true,
-          channelSid,
-          ...parsedAdditionalControlTaskAttributes,
+          timeout: controlTaskTTL || 45600, // 720 minutes or 12 hours
         }),
-        timeout: controlTaskTTL || 45600, // 720 minutes or 12 hours
-      }),
-  ]);
+    ]);
+  }
 
   const { ENVIRONMENT, HELPLINE_CODE } = context;
   let languageSanitized = language.replace('-', '_'); // Lex doesn't accept '-'