Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging a step should also include status #39

Open
kannangce opened this issue May 6, 2022 · 0 comments
Open

Logging a step should also include status #39

kannangce opened this issue May 6, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@kannangce
Copy link
Contributor

kannangce commented May 6, 2022

Problem:

When we're calling Allure.step, we're calling it without second param, which is considered success by default even if the step fails. Example, the below screenshot.

Screenshot 2022-05-06 at 10 50 13 AM

Source of issue,
Screenshot 2022-05-06 at 10 50 42 AM

Solution:
We have to call the step method with the status of the step. Not just for the the above allure logging. This need to be taken care in all the places where we log the allure status.

@kannangce kannangce added bug Something isn't working good first issue Good for newcomers labels May 6, 2022
@kannangce kannangce added this to the 0.3 milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant