Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

determine if domain is valid in 'certs:attach <cert> <domain>' #31

Open
Cryptophobia opened this issue Mar 21, 2018 · 1 comment
Open

Comments

@Cryptophobia
Copy link
Member

From @arschles on March 15, 2016 23:35

Currently, although certs:attach <cert> <domain> will properly error out if <cert> is bogus/non-existent, it doesn't if <domain> is similarly non-existent. Consider the following unit test, which is currently failing (err is nil):

if err := Attach(&client, "test-example-com", "non-existent.domain.com"); err == nil {
   t.Fatal("An Error should have resulted from the attempt to attach a valid cert to a non-existent domain")
 }

This issue tracks work on the client side, and deis/workflow#475 tracks server-side work

Copied from original issue: deis/workflow-cli#24

@Cryptophobia
Copy link
Member Author

From @Joshua-Anderson on July 18, 2016 18:56

Does this require any client side work at all? This looks entirely server side to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant