-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add ability to add new data disks to VM during clone process #29
base: main
Are you sure you want to change the base?
Conversation
/test ? |
@sbueringer: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main |
9c0f201
to
1636c16
Compare
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main |
78a0873
to
770f802
Compare
6649b60
to
f11b363
Compare
a6868e1
to
fe5b53e
Compare
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main |
2 similar comments
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main |
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main |
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main |
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main |
Not sure why it fails against the vcenter we use for e2e. Running this locally against our vcenter works. Need to look more into why either the govmomi call to add additional disks is failing or the call to get all devices / disks from the VM is not returning the new ones. |
Failure is due to kubernetes-sigs#3214 (comment) |
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main |
I made the change to pull the logic out and into its own block in the parent function. Now it should run for all clone types. |
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main |
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main pull-cluster-api-provider-vsphere-e2e-govmomi-main |
2 similar comments
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main pull-cluster-api-provider-vsphere-e2e-govmomi-main |
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main pull-cluster-api-provider-vsphere-e2e-govmomi-main |
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main pull-cluster-api-provider-vsphere-e2e-govmomi-main |
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main |
/retest (should be a unrelated flake |
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main |
Let's run again: /test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main |
/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main |
/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main |
Replicate for running e2e tests: