Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add ability to add new data disks to VM during clone process #29

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chrischdi
Copy link

@sbueringer
Copy link

/test ?

@team-cluster-api-prow
Copy link

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-31-1-32-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-31-1-32-main
  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main
  • /test pull-cluster-api-provider-vsphere-test-main
  • /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main
  • /test pull-cluster-api-provider-vsphere-janitor-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
  • pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
  • pull-cluster-api-provider-vsphere-test-main
  • pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@vr4manta vr4manta force-pushed the multi_disk branch 7 times, most recently from 9c0f201 to 1636c16 Compare October 17, 2024 18:13
@chrischdi chrischdi changed the title ✨ [WIP] Add ability to add new data disks to VM during clone process #3214 ✨ Add ability to add new data disks to VM during clone process #3214 Oct 22, 2024
@chrischdi chrischdi changed the title ✨ Add ability to add new data disks to VM during clone process #3214 ✨ Add ability to add new data disks to VM during clone process Oct 22, 2024
@chrischdi
Copy link
Author

/test help

@team-cluster-api-prow
Copy link

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-31-1-32-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-31-1-32-main
  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main
  • /test pull-cluster-api-provider-vsphere-test-main
  • /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main
  • /test pull-cluster-api-provider-vsphere-janitor-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
  • pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
  • pull-cluster-api-provider-vsphere-test-main
  • pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@vr4manta vr4manta force-pushed the multi_disk branch 4 times, most recently from 78a0873 to 770f802 Compare October 29, 2024 15:15
@vr4manta vr4manta force-pushed the multi_disk branch 2 times, most recently from 6649b60 to f11b363 Compare November 4, 2024 14:54
@vr4manta vr4manta force-pushed the multi_disk branch 5 times, most recently from a6868e1 to fe5b53e Compare November 20, 2024 17:18
@vr4manta
Copy link

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

2 similar comments
@vr4manta
Copy link

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@vr4manta
Copy link

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@vr4manta
Copy link

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@vr4manta
Copy link

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@vr4manta
Copy link

vr4manta commented Nov 25, 2024

Not sure why it fails against the vcenter we use for e2e. Running this locally against our vcenter works. Need to look more into why either the govmomi call to add additional disks is failing or the call to get all devices / disks from the VM is not returning the new ones.

@chrischdi
Copy link
Author

Not sure why it fails against the vcenter we use for e2e. Running this locally against our vcenter works. Need to look more into why either the govmomi call to add additional disks is failing or the call to get all devices / disks from the VM is not returning the new ones.

Failure is due to kubernetes-sigs#3214 (comment)

@vr4manta
Copy link

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@vr4manta
Copy link

Not sure why it fails against the vcenter we use for e2e. Running this locally against our vcenter works. Need to look more into why either the govmomi call to add additional disks is failing or the call to get all devices / disks from the VM is not returning the new ones.

Failure is due to kubernetes-sigs#3214 (comment)

I made the change to pull the logic out and into its own block in the parent function. Now it should run for all clone types.

@vr4manta
Copy link

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

@vr4manta
Copy link

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main pull-cluster-api-provider-vsphere-e2e-govmomi-main

2 similar comments
@vr4manta
Copy link

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main pull-cluster-api-provider-vsphere-e2e-govmomi-main

@vr4manta
Copy link

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main pull-cluster-api-provider-vsphere-e2e-govmomi-main

@vr4manta
Copy link

vr4manta commented Dec 2, 2024

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main pull-cluster-api-provider-vsphere-e2e-govmomi-main

@chrischdi
Copy link
Author

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@chrischdi
Copy link
Author

/retest

(should be a unrelated flake

@vr4manta
Copy link

vr4manta commented Dec 5, 2024

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@chrischdi
Copy link
Author

Let's run again:

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-31-1-32-main

@vr4manta
Copy link

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-31-1-32-main

@vr4manta
Copy link

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-31-1-32-main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants