env/option_env failing to be linted by plrustc

[thomcc]

Because this is unrelated to #387 it deserves it's own issue.

Fixing it outright seems difficult (still not sure how), I think it'd probably be fine to try wiping the env on entry to plrustc when compiling the plrust user crate though. Because it seems specific to the env macro (and not a more general thing) that should be enough.

[eeeebbbbrrrr]

It’s unclear to me what effect wiping the environment would have on Postgres. It can get some settings from the environment but I don’t know if that’s during startup only (I’d hope!) or if it happens during runtime too

[thomcc]

This would just be inside plrustc.

[eeeebbbbrrrr]

oh. well, should plrust clear the env for the cargo Command it spawns? We currently do this, but could do more:

plrust/plrust/src/user_crate/cargo.rs

Line 122 in 87a9082

fn sanitize_env(command: &mut Command) {

[thomcc]

Nah, I think we'd do this inside plrustc itself, to make sure we don't mess something up with cargo.

[thomcc]

This is pretty annoying to do correctly so I think we'll do this slightly incorrectly and hope it doesn't break anything.

[workingjubilee]

On the scale of code crimes we commit, it probably will be far from the top.

[thomcc]

... That is quite true.