Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to use configured pgx version #180

Closed
eeeebbbbrrrr opened this issue Jan 25, 2023 · 4 comments
Closed

Update CI to use configured pgx version #180

eeeebbbbrrrr opened this issue Jan 25, 2023 · 4 comments
Assignees

Comments

@eeeebbbbrrrr
Copy link
Contributor

Right now, plrust's CI installs cargo-pgx from pgx' git repo, off its develop branch.

Instead, CI should peek inside plrust/Cargo.toml and pluck out the pgx version we're using, and simply execute cargo install cargo-pgx --version $TheVersionFromCargoToml.

Assuming CI's existing caching features do what they claim, this will allow subsequent CI runs that all use the same pgx version to skip installing cargo-pgx again, possibly saving ~4 minutes per job.

@BradyBonnette
Copy link
Contributor

Yeah good idea. As mentioned in discord, I am fairly certain installing cargo-pgx from the develop branch was a relic of the past. Now that things are solidifying a bit, we should do this.

@eeeebbbbrrrr
Copy link
Contributor Author

Right now we run cargo install cargo-pgx ... --force. We don't want --force anymore if we're going to expect cargo install to skip installing the same version.

@BradyBonnette
Copy link
Contributor

Got it.

@BradyBonnette
Copy link
Contributor

@eeeebbbbrrrr #182 has been merged in, so this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants