Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] npm migrate can't migrate js packages for plugins pulled from v1 branch #10693

Closed
gknapp opened this issue Aug 20, 2024 · 3 comments · Fixed by #10794
Closed

[docs] npm migrate can't migrate js packages for plugins pulled from v1 branch #10693

gknapp opened this issue Aug 20, 2024 · 3 comments · Fixed by #10794
Assignees
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@gknapp
Copy link

gknapp commented Aug 20, 2024

I've encountered an error using tauri-plugin-store-api when upgrading my app to 2.0.0-RC4. There's no mention in the migration guide about the change to the V2 Store plugin.

Using the V1 tauri-plugin-store-api manifests as: TypeError: window.__TAURI_IPC__ is not a function

image

This is the sources tab:

image

@gknapp gknapp added the type: documentation Need to update the API documentation label Aug 20, 2024
@FabianLars
Copy link
Member

This error should mean that the npm package for the store plugin is still on v1.

@gknapp
Copy link
Author

gknapp commented Aug 20, 2024

This error should mean that the npm package for the store plugin is still on v1.

It should but it's been upgraded:

image

On the JS side I have v1 and v2 installed. I'll remove the v1 - should the migration script replace these and update calls to the v1 plugin to v2?

image

@FabianLars
Copy link
Member

should the migration script replace these and update calls to the v1 plugin to v2?

Yes this is basically still #10650 because the PR only touched on the rust packages.

@FabianLars FabianLars changed the title [docs] No mention of tauri-plugin-store-api changes in the v1 > v2 migration docs [docs] npm migrate can't migrate js packages for plugins pulled from v1 branch Aug 20, 2024
@FabianLars FabianLars added type: bug status: needs triage This issue needs to triage, applied to new issues and removed type: documentation Need to update the API documentation labels Aug 20, 2024
@lucasfernog lucasfernog self-assigned this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants