Build: Bump golang version to 1.21.10 (algorand#636)

* Bump golang version to 1.21.10 * Address new linter warnings.
tasosbit · Aug 29, 2024 · 5796da3 · 5796da3
1 parent 101b412
commit 5796da3
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 10 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -1,7 +1,7 @@
 version: 2.1
 
 orbs:
-  go: circleci/go@1.7.3
+  go: circleci/go@1.11.0
 
 workflows:
   circleci_build_and_test:
@@ -10,7 +10,7 @@ workflows:
           name: 'test_go_<< matrix.go_version >>'
           matrix:
             parameters:
-              go_version: ['1.20.14']
+              go_version: ['1.21.10']
 
 jobs:
   test:

diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml
@@ -12,17 +12,17 @@ jobs:
       - name: Install specific golang
         uses: actions/[email protected]
         with:
-          go-version: '1.20.14'
+          go-version: '1.21.10'
       - name: Check format
         run: test -z `go fmt ./...`
       - name: Vet
         run: go vet ./...
       - name: reviewdog-golangci-lint
-        uses: reviewdog/action-golangci-lint@v2.3.1
+        uses: reviewdog/action-golangci-lint@v2.6.1
         with:
-          golangci_lint_version: "v1.53.2"
+          golangci_lint_version: "v1.58.0"
           golangci_lint_flags: "-c .golangci.yml --allow-parallel-runners"
-          go_version: "1.20.14"
+          go_version: "1.21.10"
           reporter: "github-pr-review"
           tool_name: "Lint Errors"
           level: "error"

diff --git a/go.mod b/go.mod
@@ -1,6 +1,8 @@
 module github.com/algorand/go-algorand-sdk/v2
 
-go 1.20
+go 1.21
+
+toolchain go1.21.10
 
 require (
 	github.com/algorand/avm-abi v0.1.1

diff --git a/go.sum b/go.sum
@@ -3,6 +3,7 @@ github.com/algorand/avm-abi v0.1.1/go.mod h1:+CgwM46dithy850bpTeHh9MC99zpn2Snirb
 github.com/algorand/go-codec/codec v1.1.10 h1:zmWYU1cp64jQVTOG8Tw8wa+k0VfwgXIPbnDfiVa+5QA=
 github.com/algorand/go-codec/codec v1.1.10/go.mod h1:YkEx5nmr/zuCeaDYOIhlDg92Lxju8tj2d2NrYqP7g7k=
 github.com/chrismcguire/gobberish v0.0.0-20150821175641-1d8adb509a0e h1:CHPYEbz71w8DqJ7DRIq+MXyCQsdibK08vdcQTY4ufas=
+github.com/chrismcguire/gobberish v0.0.0-20150821175641-1d8adb509a0e/go.mod h1:6Xhs0ZlsRjXLIiSMLKafbZxML/j30pg9Z1priLuha5s=
 github.com/cucumber/godog v0.8.1 h1:lVb+X41I4YDreE+ibZ50bdXmySxgRviYFgKY6Aw4XE8=
 github.com/cucumber/godog v0.8.1/go.mod h1:vSh3r/lM+psC1BPXvdkSEuNjmXfpVqrMGYAElF6hxnA=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

diff --git a/test/docker/Dockerfile b/test/docker/Dockerfile
@@ -1,4 +1,4 @@
-ARG GO_IMAGE=golang:1.20.14
+ARG GO_IMAGE=golang:1.21.10
 FROM $GO_IMAGE
 
 # Copy SDK code into the container

diff --git a/test/helpers.go b/test/helpers.go
@@ -52,7 +52,7 @@ func mockHTTPResponsesInLoadedFromHelper(jsonfiles, directory string, status int
 		responseRing.Value = json
 		responseRing = responseRing.Next()
 	}
-	mockServer = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	mockServer = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 		json := responseRing.Value.([]byte)
 		if status > 0 {
 			w.WriteHeader(status)
@@ -67,7 +67,7 @@ var receivedMethod string
 var receivedPath string
 
 func mockServerRecordingRequestPaths() error {
-	mockServer = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	mockServer = httptest.NewServer(http.HandlerFunc(func(_ http.ResponseWriter, r *http.Request) {
 		receivedMethod = r.Method
 		receivedPath = r.URL.String()
 	}))