Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filling default Parameters should avoid expensive operations #616

Open
glandium opened this issue Dec 18, 2024 · 0 comments
Open

Filling default Parameters should avoid expensive operations #616

glandium opened this issue Dec 18, 2024 · 0 comments

Comments

@glandium
Copy link
Contributor

The default for files_changed is to do a somewhat expensive repo.get_changed_files call. It's aggravated by gecko_taskgraph having its own default that uses repo.get_locally_changed_files, which can be even more expensive.
But out-of-tree extension of the parameters schema (per extend_parameters_schema) is not the only way the value may be uselessly computed: one may call Parameters(files_changed=...), and both values that were computed above end up thrown away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant