Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making a regression_data fixture in conftest.py #416

Open
jvshields opened this issue Nov 4, 2024 · 0 comments
Open

Consider making a regression_data fixture in conftest.py #416

jvshields opened this issue Nov 4, 2024 · 0 comments

Comments

@jvshields
Copy link
Contributor

#413 sets up regression data, but needs to import the regression_data class in to conftest.py. Ruff wants to remove the import, so we added an assert statement to make ruff not remove it.

This maybe points to the fact that we should have a regression_data pytest fixture initialized in conftest.py, since conftest.py is largely the place to create such fixtures and this change seems in line with that idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant