Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable as many warnings as possible #83

Open
drewdzzz opened this issue Dec 14, 2023 · 0 comments
Open

Enable as many warnings as possible #83

drewdzzz opened this issue Dec 14, 2023 · 0 comments
Labels
build issue The issue describes the problem with the build code health Improve code readability, simplify maintenance and so on

Comments

@drewdzzz
Copy link
Collaborator

drewdzzz commented Dec 14, 2023 •
edited
Loading

As a header-only library, tntcxx have to meet high code quality standards.

In any serious project, -Werror compilation flag is set, which causes any warning in tntcxx to break build of a project that uses it, and developers have to disable this warning for their project. That is why we should enable as many warnings as possible.

Recommended by Red Hat compiler flags can be found here. Here is a selection of the most popular options from the author. We also can look at other open-source projects. For example, oatpp enables all the available warnings (or almost all).

Generalization of #80
@drewdzzz drewdzzz added code health Improve code readability, simplify maintenance and so on build issue The issue describes the problem with the build labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build issue The issue describes the problem with the build code health Improve code readability, simplify maintenance and so on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drewdzzz