Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Ignore the vote_result of subsequent signing sets if one signing set has successfully signed proposal #599

Open
1xstj opened this issue May 10, 2023 · 0 comments
Labels
optimization ⚙️ Tasks that are refactor, optimize, or are considered chores. p3 🔵 Issues should be resolved eventually

Comments

@1xstj
Copy link
Contributor

1xstj commented May 10, 2023

Task summary
In the current situation, we process a proposal to be signed by multiple signing sets for redundancy. This ensures that atleast one signing set can succesfully sign a proposal in the worst case. But in the best case all the signing sets will sign the proposal and store in the offchain storage. This will break the proposal handler verification since we submit multiple signed versions of the same proposals.

In #577 we have taken the simpler approach of not adding a signed proposal to offchain storage if it exists and is already signed by another signing set. We could improve this so that when a proposal with a proposal_hash is signed we can abandon all the other threads that are in the process of signing the same proposal. This way we do not do any extra computation and can help us when we have a huge unsigned proposal backlog.

@1xstj 1xstj added p3 🔵 Issues should be resolved eventually optimization ⚙️ Tasks that are refactor, optimize, or are considered chores. labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization ⚙️ Tasks that are refactor, optimize, or are considered chores. p3 🔵 Issues should be resolved eventually
Projects
None yet
Development

No branches or pull requests

1 participant