Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Ensure all unwrap is removed and add check to CI #572

Closed
Tracked by #573
1xstj opened this issue Apr 13, 2023 · 1 comment · Fixed by #584
Closed
Tracked by #573

[TASK] Ensure all unwrap is removed and add check to CI #572

1xstj opened this issue Apr 13, 2023 · 1 comment · Fixed by #584
Assignees
@1xstj

Comments

@1xstj
Copy link
Contributor

1xstj commented Apr 13, 2023 •
edited
Loading

Task summary
Remove all unwrap() in pallet code, add [deny(clippy::unwrap_used)] to lint check CI so that we catch any regression

#569
@1xstj 1xstj mentioned this issue Apr 13, 2023
Open
4 tasks
@1xstj 1xstj self-assigned this Apr 13, 2023
@github-project-automation github-project-automation bot moved this to Not Started 🕧 in Webb Universe Apr 13, 2023
@1xstj 1xstj moved this from Not Started 🕧 to Planning 🗺️ in Webb Universe Apr 13, 2023
@Nutomic
Copy link
Contributor

Nutomic commented Apr 13, 2023

You can copy the changes I made in relayer for this, it also includes some other potential crashes such as accessing a Vec with [] operator.

tangle-network/relayer#408

@1xstj 1xstj mentioned this issue Apr 26, 2023
Merged
@1xstj 1xstj moved this from Planning 🗺️ to Building 🏗️ in Webb Universe Apr 26, 2023
@github-project-automation github-project-automation bot moved this from Building 🏗️ to Completed ✅ in Webb Universe Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1xstj 1xstj

Labels
None yet
Projects
Webb Universe
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove all unwraps from runtime code tangle-network/dkg-substrate
2 participants
@Nutomic @1xstj