Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usable without network #5

Open
2 tasks
tanghus opened this issue Sep 9, 2019 · 1 comment
Open
2 tasks

Usable without network #5

tanghus opened this issue Sep 9, 2019 · 1 comment

Comments

@tanghus
Copy link
Owner

tanghus commented Sep 9, 2019

The title used to be "Crash when no network!", but I can't reproduce the crash.

The app needs to be usable without network, as long as the currency pairs needed are cached.

Outstanding issues:

  • When network disconnects, the busyindicator starts spinning, and doesn't stop again when a connection is established.
  • What to do if the service if offline? Signal ExchangeProvider to try to load cache again => separate cache loading to own method.
@tanghus tanghus added the bug label Sep 9, 2019
@tanghus tanghus added this to the Version 0.3 milestone Sep 9, 2019
@tanghus tanghus pinned this issue Sep 9, 2019
@tanghus
Copy link
Owner Author

tanghus commented Sep 10, 2019

Related: 929eca1

@tanghus tanghus changed the title Crash when no network! Usable without network Sep 11, 2019
@tanghus tanghus added ready Completed, but needs testing before release and removed bug labels Sep 11, 2019
@tanghus tanghus removed the ready Completed, but needs testing before release label Sep 21, 2019
@tanghus tanghus unpinned this issue Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant