-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-Launch Theme Testing #28
Comments
Great I'll start working my way through it as soon as you give the word to begin testing. As far as 1) goes I can validate email with my dev environment. I'll try validating both ways though for the sake of user testing. |
Go ahead and start as soon as you have time. I'd just say to make sure to pull down recent commits every time before you start as I'm going to be making a lot of little updates this week. |
Hey Jasper, I've deprecated the use of the bp-custom file, you can safely delete it. See the commit "Improved BuddyPress and bbPress Initialization" from October 6 for more details. |
Ok will do. I'd suggest wrapping all class definitions with the following to add more resiliency to the code:
|
Yeah, I recognize the value of that code snippet...but frankly, if anyone On Tue, Oct 8, 2013 at 3:37 PM, Jasper Valero [email protected]:
|
Well TBH someone trying to redefine an existing class via writing another class is a very rarely the use case for the above snippet. The use case is for a scenario just like what happened with me. Something gets moved around or a file is copied somewhere, but another version remains elsewhere. In all things code... resiliency should be implemented. Be careful rationalizing in a vacuum. It will compromise your coding technique and cause you to build up what I call "code debt". Coding improves with practice, so always practice the best way of doing things regardless the size or scope of the project. P.S. It's one thing if you don't know about a technique, which I realize you probably didn't. But now you do. ;) |
Fair enough. Do you anticipate having any time around TS tonight or On Tue, Oct 8, 2013 at 3:46 PM, Jasper Valero [email protected]:
|
Honestly, TBD. Trying hard though. I can swing a Skype IM if that works for you? |
yeah, Skype is always useful. I'm on all the time if I'm home. On Tue, Oct 8, 2013 at 5:28 PM, Jasper Valero [email protected]:
|
[Issue] Dark BG for text input on new post form, I'm guessing this is more of a sitewide issue. Again will dig into this after I go through list. [Success] Able to make new post. [Question] Similar to comment question in #3 above. After posting a reply to thread, form rolls up and post rolls down. Reply form is no longer displayed until user refreshes the page. [Issue] Topic tag box shows up on reply form. I believe this should be just for new posts. [Success] Able to utilize moderation tools. [Success] Reported post. [Issue] 404 on "Best Weekly Topics" |
Hey Jasper, thanks for this progress. Some responses (numbered by testing task)
|
[Success] Able to post update to profile. [Success] Able to post update on/via sitewide activity feed. |
[Success] All filters seem to be working. |
[Success] All filters on members directory appear to work. |
[Question] Is this one a duplicate of 10) or am I missing something? |
[Success] These same panels are part of the new guild creation process. I did test changes via these panels after guild creation though and everything seems to work. |
Worked fine for me...I guess we'll need to look more at this. Can you figure out why it's failing on your end? Is it an issue in the JS/AJAX or an issue with the PHP?
I think most of the time people will be taken directly to the compose form by using the "Private Message" link on someone's user profile.
Sitewide notices aren't an included component at this point in time. Site admins are the only ones that see this checkbox, so I'm content to leave as-is for now.
You'll need the bbPress core hack which I mentioned earlier for this checkbox to show up
There's two "new guild" forms. One that site admins get that actually performs the function of creating a new guild: |
In your testing thus-far, do you have any general thoughts about the overall layout or feel of the theme, apart from the does it work/not work checks? |
Have you had the chance to make any further progress with some of this testing? What is your availability looking like for the next 3 days? I would really like to make sure everything is squared away for Sunday. |
[Success] After you explained the difference, I was able to successfully complete #10 and #11.
[Success] I ran into no issues on the guild admin panels.
[Success] Able to join guild on multiple accounts. [Success] Guild activities, invitations, updates seem to work. [Issue] Custom group file in place but still no check box: [Issue] Group Forum selection dropdown exposes main forum threads to assign to a group. Should only show custom group forums. Perhaps this is an admin feature, but either way it would be a lot safer if we removed our actual TF forums from the dropdown. [Issue] Cannot test group forums. Unable to see checkbox, also unable to set via Group Forum. When you click save settings it resets back to "(No Forum)".
[Success] Able to browse through the guild directory using all sorting/filtering options and no issues seen.
[Success] Able to successfully submit contact form.
[Issue] I saw your comment and know you just wanted to get this done, but consider this confirmation that advanced search is not up to snuff as of yet. Will need some TLC after launch. At the very least need to cluster fields for different search types and add more spacing and padding. Everything looks clumped and because everything is displayed at once there is duplication of fields. [Issue] Search form does not seem to work. I'll have another look at this when I get home though. Not seeing any errors, search button seems to do nothing. |
Hey jasper, Thanks for continuing with this. I only have a minute before a meeting, but regarding adv search, you are looking at the wrong thing i think. Looks like you are referencing your old in-progress template instead of the new form Sent from my iPhone On Oct 11, 2013, at 1:19 PM, Jasper Valero [email protected] wrote:
|
Yeah I figured it was something like that. Was interrupted before I could On Friday, October 11, 2013, Andrew wrote:
|
Okay well I can access the page but nothing shows up. The part where the form would be is empty. And passing params doesn't seem to help. |
[Success] Was unable to find issues while trying to break the login system.
[Success] All links working in nav and admin bar. [Success] Notifications back and forth working fine. Able to manually clear notifications
[Success] Able to successfully cast votes for posts. BTW, big LOL on "This got ugly". Love it man. [Success] Best topics looks good. I think this will be a really likeable feature. Better than I initially thought.
[Success] Successfully unlocked, TF team, grouped, ER and allegiance badges.
[Success] Unable to break avatar uploading. All uploads successful. |
Thanks for the feedback on some of the other points. So... today is the day (unless we encounter any major issues in the next several hours). Some stuff is still not finished, and I'm going to be scrambling to get everything ready. I can handle almost everything myself, but it's pretty clear I don't understand what to do with the images that need to be optimized, and I could really use a hand getting that taken care of. IF you have any time today to do that, it would be great, because at the moment our header and background images are too big to launch with (imo). |
As a follow up to the above, it would be great if you could drop by TeamSpeak at some point to help out with that, if not...no worries. I would prefer you don't do anything unless we are in direct voice communication about it today. If you can help out in TS during the launch that would be awesome, but if not I'll do my best to downsize hte images some myself. |
Here are some testing goals for the new theme:
Register a new user account. You won't be able to "activate" the account on your local test site, since this requires email validation. You can use the plugin "BuddyPress Pending Activations" - http://wordpress.org/plugins/buddypress-pending-activations/ to manually activate pending accounts.
Fully configure a user profile. Try all sorts of different race/class/faction combinations. Play around with signature and biography formatting options. Change your email address and password. Change your notification preferences.
Browse through articles. Look at author and category archives. Play around with commenting on front-page articles. Edit and delete article comments. Report article comments.
Create new forum posts, reply to them, moderate them. Report forum posts.
Perform merge, split, move, and edit operations on multiple forum posts.
Add other users as friends, send public and private messages. Issue another user an infraction, and post moderator notes on their profile. Send private messages to a group of users.
Post status updates on your user profile, and the main sitewide activity feed.
Use the activity feed to filter for all sorts of different content options.
Use the members directory to browse the new users you have created and sort them on different criteria.
Submit a new guild using the guild submission form.
Create some new guilds using the guild creation form.
Fully customize and configure guild options using the administration panels.
Join a guild on multiple user accounts. Play around with guild activity feeds, invitations, status updates, and private forums.
Browse through multiple guilds on the guild directory. Use sorting and filtering options.
Submit a contact form.
Use the advanced search form to search for different combinations of results.
Try to break the login system.
Experiment with the admin bar and navigation menu. Make sure all the links work. Send different types of notifications back and forth between two user accounts. Manually clear notifications.
Create new forum posts and give them "This Thread Rocks" votes on different user accounts. Experiment with the "Best-Of Topics" listing.
Try to unlock some profile badges.
Try to break avatar uploading.
I may think of more...but this is enough for a couple days of testing I think. For each item, think about layout, design, and usability. Is there some javascript that we could add to enhance the user experience? Does the CSS layout look a bit wierd in places? Is it hard to figure out how to do any of the above items? I know you are less familiar with the theme than I am, so use that to your advantage. Let me know what trips you up, or doesn't make sense.
The text was updated successfully, but these errors were encountered: