Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #155

Open
vmesel opened this issue Mar 13, 2024 · 5 comments
Open

Increase test coverage #155

vmesel opened this issue Mar 13, 2024 · 5 comments

Comments

@vmesel
Copy link
Member

vmesel commented Mar 13, 2024

We need to add testing for LCEL, Abstract and Default LLMs and the API parts of the code.

@vmesel vmesel changed the title Add testing on LLMs Increase test coverage Mar 16, 2024
@vmesel
Copy link
Member Author

vmesel commented Mar 16, 2024

Right now we have the following coverage:

---------- coverage: platform linux, python 3.11.8-final-0 -----------
Name                            Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------------
dialog/learn/helpers.py             1      0      0      0   100%
dialog/learn/idf.py                11      6      2      0    38%   14-19
dialog/llm/__init__.py             20     13      4      0    29%   12-29
dialog/llm/abstract_llm.py         38      9     10      1    75%   24, 73, 80-89
dialog/llm/default.py              48     29     16      0    36%   23-28, 31-59, 63-84, 87-89
dialog/llm/embeddings.py           18      8      2      0    50%   16, 23, 27-41
dialog/llm/lcel_default.py         52     52     16      0     0%   1-110
dialog/llm/memory.py               32     11      4      0    58%   34-37, 41-47, 67-71
dialog/models/__init__.py          27      6      0      0    78%   18-19, 27-28, 40-41
dialog/models/db.py                 8      0      0      0   100%
dialog/models/helpers.py           12      0      4      2    88%   8->11, 12->17
dialog/schemas/__init__.py          1      0      0      0   100%
dialog/schemas/api_schemas.py       5      0      0      0   100%
dialog/settings.py                 23      0      2      0   100%
load_csv.py                        41     41     16      0     0%   1-72
main.py                            72     14     20      4    80%   62-63, 76, 112, 127, 133-142
---------------------------------------------------------------------------
TOTAL                             409    189     96      7    50%
4 empty files skipped.
============================== 7 passed in 4.68s ===============================

@vmesel
Copy link
Member Author

vmesel commented Apr 7, 2024

#171 made a improvement on 9%, totaling our coverage to 59% if approved

@alexfilothodoros
Copy link

Hi @vmesel
Are you still intested in this issue? I was thinking that I could help with that.

@vmesel
Copy link
Member Author

vmesel commented Jun 6, 2024

Hey @alexfilothodoros, yes! We are interested!

@alexfilothodoros
Copy link

Awesome! I will try to set up everything during the weekend and start working on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants