Adding query param support for custom search engines in browsers #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't feel strongly about the tool versions or yarn lock changes if you want to toss them |
|
@khatabwedaa any chance you could take a look? |
|
@heysweet, hey man sorry for not responding, I've been so busy the last few months but I will check it now. |
|
@heysweet I just text the PR thank you for your awesome work just one think I want you to remove the quarry form URL if it's empty |
|
Just pushed a fix for that, good catch! |
|
Thanks for your awesome work @heysweet . 😄 I merged it I will deploy it today so you can check it live. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50 (comment)
Lots of browsers support Custom Search Engines. This change would allow me to type "tw" -> hit tab -> and type in a search term, and then I could open the tailwind cheatsheet to the specific query I'm thinking of. It'd be a huge ergonomic win!
I know that my implementation of this change isn't up to today's standards, but I didn't want to go through upgrading all of the packages to unlock
useSearchParamsfromreact-router-dom(I tried and found a few other dependencies onhistorythat made this upgrade a larger swing than I wanted to take on.)