fix(kit): CalendarRange not update selectedActivePeriod, when value updates
#8536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
mdlufy
changed the title
CalendarRange not update selectedActivePeriod, when value updatesCalendarRange not update selectedActivePeriod, when value updates
|
Visit the preview URL for this PR (updated for commit 1f6cbb4): https://taiga-previews--pr8536-mdlufy-calendar-rang-jyv8oq4b.web.app (expires Thu, 15 Aug 2024 17:10:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a |
splincode
reviewed
Aug 14, 2024
projects/kit/components/calendar-range/calendar-range.component.ts
Outdated
Show resolved
Hide resolved
splincode
reviewed
Aug 14, 2024
projects/kit/components/calendar-range/calendar-range.component.ts
Outdated
Show resolved
Hide resolved
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +67B +0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
mdlufy
force-pushed
the
mdlufy/calendar-range-checkbox
branch
from
3b82ab0 to
1f6cbb4
Compare
mdlufy
changed the title
CalendarRange not update selectedActivePeriod, when value updatesCalendarRange not update selectedActivePeriod, when value updates
mdlufy
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin and
nsbarsukov
as code owners
splincode
approved these changes
Aug 14, 2024
|
Closing in favor of #8595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8527
After update value:
As Is:
as-is.mov
To Be:
to-be.mov