Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix flaky #6685

Merged
merged 1 commit into from
Feb 6, 2024
Merged

chore: fix flaky #6685

merged 1 commit into from
Feb 6, 2024

Conversation

splincode
Copy link
Member

No description provided.

Copy link

lumberjack-bot bot commented Feb 5, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Feb 5, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
329.53KB +10%
demo/browser/vendor.(hash).js
214.27KB +10%
demo/browser/runtime.(hash).js
34.18KB +10%
demo/browser/styles.(hash).css
13.67KB +10%
demo/browser/polyfills.(hash).js
11.24KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.17MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Visit the preview URL for this PR (updated for commit b021197):

https://taiga-ui--pr6685-splincode-fix-test-e-4ozptdtl.web.app

(expires Tue, 06 Feb 2024 10:02:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Comment on lines 52 to +54
cy.get('#scroll')
.then(query => query.get(0).scrollTo({top: 75}))
.then(() => cy.wait(100))
.then(() => cy.wait(300))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use Cypress API ?
https://docs.cypress.io/api/commands/scrollTo

cy.get('#scroll').scrollTo().then(...);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't work

@splincode splincode merged commit f3d19e1 into main Feb 6, 2024
29 checks passed
@splincode splincode deleted the splincode/fix-test-elastic branch February 6, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants