Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 - Accordion component in Firefox closes immediatelly instead of showing animation for collapse #8973

Closed
2 of 9 tasks
konverso-aakulov opened this issue Sep 11, 2024 · 3 comments · Fixed by #10103
Closed
2 of 9 tasks
Labels
P3 This issue has low priority S3 This issue has low severity

Comments

@konverso-aakulov
Copy link

Playground Link

No response

Description

I took the Basic example from the official documentation without any modification (https://taiga-ui.dev/components/accordion#base) and added it to the new project with only Taiga UI added (no other UI kits or dependencies).

It works, except the strange animation behavior for the first and last element in latest Firefox. Sometimes, when I click on the last element to expand and the first element is already expanded, then the first element collapses without animation. The last element is animated properly. And vise versa.

If I do the same for first and second items or for second and the third then everything works fine.

The issue does not appear on the documentation page, but appears on the Stackblitz example from the doc page.

In Chrome everything works fine.

Angular version

18.2.3

Taiga UI version

4.6.0

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@waterplea waterplea added P3 This issue has low priority S3 This issue has low severity contributions welcome Architecture is clear and community can help and removed state: need triage labels Sep 17, 2024
@waterplea
Copy link
Collaborator

I wonder if it can be possible to drop our own transition implementation and just use Angular animations for height transition. Back when we created it it wasn't a thing I believe. And the only reason for using custom transition is because CSS cannot transition from/to auto which Angular animations can do.

@Kulikov17
Copy link

This problem is also observed in tui-expand and not only with the first and last element

@waterplea waterplea removed the contributions welcome Architecture is clear and community can help label Nov 6, 2024
@waterplea
Copy link
Collaborator

We should probably completely rework expand to Angular animations, instead of doing height calculations ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 This issue has low priority S3 This issue has low severity
Development

Successfully merging a pull request may close this issue.

4 participants