Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kit): CalendarRange click again on selected item not switch to item date #8843

Merged
merged 4 commits into from
Sep 10, 2024
Merged

fix(kit): CalendarRange click again on selected item not switch to item date #8843

merged 4 commits into from
Sep 10, 2024

Conversation

mohan-mu
Copy link
Contributor

@mohan-mu mohan-mu commented Sep 5, 2024 •
edited by splincode
Loading

Close #8820 , #8780

Screen.Recording.2024-09-05.at.7.35.32.PM.mov

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 5, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.69%. Comparing base (43c0ebb) to head (1ed2068).
Report is 1570 commits behind head on main.

Files with missing lines Patch % Lines
...ponents/calendar-range/calendar-range.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8843      +/-   ##
==========================================
+ Coverage   70.19%   75.69%   +5.49%     
==========================================
  Files        1460     1216     -244     
  Lines       15934    19066    +3132     
  Branches     2292     1961     -331     
==========================================
+ Hits        11185    14432    +3247     
- Misses       4369     4593     +224     
+ Partials      380       41     -339
Flag Coverage Δ
summary 75.69% <0.00%> (+5.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 5, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 283.38KB (+21B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 216.48KB +10%
✅ demo/browser/runtime.(hash).js
 42.17KB +10%
✅ demo/browser/styles.(hash).css
 12.81KB +10%
✅ demo/browser/polyfills.(hash).js
 11.2KB +10%

Total files change +21B 0%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 6.99MB (+21B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@splincode splincode changed the title fix(kit): CalendarRange click again on selected item not switch to it… fix(kit): CalendarRange click again on selected item not switch to item date Sep 5, 2024
@mohan-mu
Copy link
Contributor Author

mohan-mu commented Sep 5, 2024

Hi @mdlufy ,
Could you Review and Validate

@mdlufy
Copy link
Collaborator

mdlufy commented Sep 6, 2024 •
edited
Loading

image @mohan-mu, why did the deep range allocation disappear in this example test? It confuses me

@mohan-mu
Copy link
Contributor Author

mohan-mu commented Sep 6, 2024

image @mohan-mu, why did the deep range allocation disappear in this example test? It confuses me

Fixed it

@splincode splincode self-requested a review September 9, 2024 10:04
@mdlufy
Copy link
Collaborator

mdlufy commented Sep 9, 2024 •
edited
Loading

@mohan-mu Rebase your fork please, due to our main branch has changes
And check reproduce on this case #8911 on your fix

@mohan-mu mohan-mu requested a review from mdlufy September 9, 2024 16:07
@splincode splincode merged commit 4853671 into taiga-family:main Sep 10, 2024
28 checks passed
@mdlufy
Copy link
Collaborator

mdlufy commented Sep 10, 2024

@mohan-mu looks nice, th 👍

@mdlufy
Copy link
Collaborator

mdlufy commented Sep 10, 2024

@mohan-mu if you want, you can try to fix the issue #8820 for v3
https://github.com/taiga-family/taiga-ui/tree/v3.x

@mohan-mu
Copy link
Contributor Author

Thanks @mdlufy , Let me take a Look

@mdlufy mdlufy mentioned this pull request Sep 10, 2024
Closed
@taiga-family-bot taiga-family-bot mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlufy mdlufy mdlufy approved these changes

@splincode splincode splincode approved these changes

@waterplea waterplea Awaiting requested review from waterplea

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - CalendarRange click again on selected item not switch to item date
3 participants
@mohan-mu @mdlufy @splincode