Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 - tui-input-password does not display the view/hide password button #6973

Closed
2 of 9 tasks
NickMih opened this issue Mar 11, 2024 · 3 comments · Fixed by #8584
Closed
2 of 9 tasks

🐞 - tui-input-password does not display the view/hide password button #6973

NickMih opened this issue Mar 11, 2024 · 3 comments · Fixed by #8584
Labels
community contribution This issue was closed by a PR from the community P3 This issue has low priority S3 This issue has low severity

Comments

@NickMih
Copy link

NickMih commented Mar 11, 2024

Playground Link

https://stackblitz.com/edit/angular-n6jrjp?file=src%2Fapp%2Fapp.component.html

Description

Can you add [showButtons] directory in 3-th version? Because readOnly attribute can't work with dynamic form.

Angular version

17

Taiga UI version

3.69

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@waterplea
Copy link
Collaborator

Disabled element is meant to be completely non-interactive. It is missing from the form, it is missing from accessibility tools, browsers typically ignore pointer events on it. I believe we should only show this icon for readonly controls as you can focus them, select and copy content etc.

@waterplea waterplea added contributions welcome Architecture is clear and community can help P3 This issue has low priority S3 This issue has low severity and removed state: need triage labels Mar 19, 2024
@Debxit
Copy link

Debxit commented Jul 2, 2024

Disabled element is meant to be completely non-interactive. It is missing from the form, it is missing from accessibility tools, browsers typically ignore pointer events on it. I believe we should only show this icon for readonly controls as you can focus them, select and copy content etc.

Hi, can you clarify what should be done? I want to try to contribute, but didn't get the final idea.

@waterplea
Copy link
Collaborator

@Debxit right now InputPassword does not display eye icon for disabled and readOnly state. It should display icons for readOnly and only hide icons for disabled state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This issue was closed by a PR from the community P3 This issue has low priority S3 This issue has low severity
Development

Successfully merging a pull request may close this issue.

3 participants