From 781cb6a1680903f361647ab180cb12bb9ec36caf Mon Sep 17 00:00:00 2001 From: Maksim Ivanov Date: Thu, 3 Oct 2024 15:16:04 +0300 Subject: [PATCH] chore: cleanup e2e (#9333) --- .github/screenshot-bot.config.toml | 2 +- .github/workflows/e2e-playwright.yml | 2 +- .github/workflows/snapshots.yml | 2 +- projects/demo-playwright/tests/ssg.spec.ts | 13 ------------- 4 files changed, 3 insertions(+), 16 deletions(-) delete mode 100644 projects/demo-playwright/tests/ssg.spec.ts diff --git a/.github/screenshot-bot.config.toml b/.github/screenshot-bot.config.toml index a161201598bf..8b0465027d64 100644 --- a/.github/screenshot-bot.config.toml +++ b/.github/screenshot-bot.config.toml @@ -22,4 +22,4 @@ branchesIgnore = ["^release/.*", "^v[0-9].x$"] screenshotImageAttrs = [] # Text which is placed at the beginning of section "Failed tests" -failedTestsReportDescription = '**Before <= Diff => After**' +failedTestsReportDescription = '### Before (main) <= Diff => After (local)' diff --git a/.github/workflows/e2e-playwright.yml b/.github/workflows/e2e-playwright.yml index 491f19103a33..04f75b7aa45c 100644 --- a/.github/workflows/e2e-playwright.yml +++ b/.github/workflows/e2e-playwright.yml @@ -17,7 +17,7 @@ jobs: - uses: taiga-family/ci/actions/setup/node@v1.93.0 - name: Building demo-app of git-branch without cache - run: npx nx build demo + run: npx nx build demo # Don't use prerender please, because it's flaky for e2e - name: Upload cache / ${{ env.CACHE_DIST_KEY }} uses: actions/cache/save@v4.0.2 diff --git a/.github/workflows/snapshots.yml b/.github/workflows/snapshots.yml index 83f1f0a13a6b..92a7541db5f2 100644 --- a/.github/workflows/snapshots.yml +++ b/.github/workflows/snapshots.yml @@ -19,7 +19,7 @@ jobs: - uses: taiga-family/ci/actions/setup/variables@v1.93.0 - uses: taiga-family/ci/actions/setup/node@v1.93.0 - - run: npx nx build demo + - run: npx nx build demo # Don't use prerender please, because it's flaky for e2e - run: tree ${{ env.DIST }} -P '*.html' - uses: s0/git-publish-subdir-action@v2.6.0 diff --git a/projects/demo-playwright/tests/ssg.spec.ts b/projects/demo-playwright/tests/ssg.spec.ts deleted file mode 100644 index e522466dccfb..000000000000 --- a/projects/demo-playwright/tests/ssg.spec.ts +++ /dev/null @@ -1,13 +0,0 @@ -import {expect, test} from '@playwright/test'; - -test.describe('SSG', () => { - test.use({ - javaScriptEnabled: false, - }); - - test('has prerendered landing by Angular Universal', async ({page}) => { - await page.goto('/', {waitUntil: 'domcontentloaded'}); - - await expect(page).toHaveScreenshot('ssg.png'); - }); -});