Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 - Merge MaskitoElementPredicateAsync & MaskitoElementPredicate into the single type #607

Closed
nsbarsukov opened this issue Oct 18, 2023 · 0 comments · Fixed by #757
Closed
Assignees
Labels
2.x.x Candidate for 2.0.0 release feature New feature or request

Comments

@nsbarsukov
Copy link
Member

Which package(s) are relevant/related to the feature request?

@maskito/core

Description

Maskito 1.x.x:

export type MaskitoElementPredicate = (
element: HTMLElement,
) => HTMLInputElement | HTMLTextAreaElement; // TODO: add `Promise<HTMLInputElement | HTMLTextAreaElement>`
// TODO: delete in v2.0
export type MaskitoElementPredicateAsync = (
element: HTMLElement,
) => Promise<HTMLInputElement | HTMLTextAreaElement>;

Maskito 2.x.x:

export type MaskitoElementPredicate = (
    element: HTMLElement,
) => HTMLInputElement | HTMLTextAreaElement | Promise<HTMLInputElement | HTMLTextAreaElement>;

// MaskitoElementPredicateAsync is deleted
@nsbarsukov nsbarsukov added feature New feature or request 2.x.x Candidate for 2.0.0 release labels Oct 18, 2023
@github-project-automation github-project-automation bot moved this to 💡 Backlog in Taiga-family Oct 18, 2023
@nsbarsukov nsbarsukov self-assigned this Dec 12, 2023
@github-project-automation github-project-automation bot moved this from 💡 Backlog to ✅ Done in Taiga-family Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x.x Candidate for 2.0.0 release feature New feature or request
Projects
No open projects
Status: Done
1 participant