build: remove commit hook for git-cz #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Prepare commit message" hook runs not only on commit, but also on a variety of other git tasks such as rebase and merge, sometimes in an automated way from IDE (Jetbrains IDEs do that). git-cz utility wasn't built with this in mind, and leads to bad developer experience. We can use already existing `npm run commit` script for this. Also `"prepare"` npm hook runs when a package is packaged (`npm pack`), and `husky` is intended to be run on install.
rahulyadav-57
approved these changes
Oct 28, 2024
verytactical
added a commit
that referenced
this pull request
Oct 29, 2024
"Prepare commit message" hook runs not only on commit, but also on a variety of other git tasks such as rebase and merge, sometimes in an automated way from IDE (Jetbrains IDEs do that). git-cz utility wasn't built with this in mind, and leads to bad developer experience. We can use already existing `npm run commit` script for this. Also `"prepare"` npm hook runs when a package is packaged (`npm pack`), and `husky` is intended to be run on install.
verytactical
added a commit
that referenced
this pull request
Oct 29, 2024
"Prepare commit message" hook runs not only on commit, but also on a variety of other git tasks such as rebase and merge, sometimes in an automated way from IDE (Jetbrains IDEs do that). git-cz utility wasn't built with this in mind, and leads to bad developer experience. We can use already existing `npm run commit` script for this. Also `"prepare"` npm hook runs when a package is packaged (`npm pack`), and `husky` is intended to be run on install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Prepare commit message" hook runs not only on commit, but also on a variety of other git tasks such as rebase and merge, sometimes in an automated way from IDE (Jetbrains IDEs do that). git-cz utility wasn't built with this in mind, and leads to bad developer experience. We can use already existing
npm run commitscript for this.Also
"prepare"npm hook runs when a package is packaged (npm pack), andhuskyis intended to be run on install.Closes #139