Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten attributes in attributes/default.rb #18

Open
bignastybryce opened this issue Feb 19, 2015 · 0 comments
Open

Flatten attributes in attributes/default.rb #18

bignastybryce opened this issue Feb 19, 2015 · 0 comments

Comments

@bignastybryce
Copy link
Collaborator

Assigning attributes as hashes can cause some odd behavior during the merge. The attributes should be flattened to single values per assignment where possible. I know this takes a lot more typing, and I also know that I was the one who did it like this in the first place. I can only plead youth(!?) and ignorance. Might as well change the keys to strings instead of symbols while you're at it, to make foodcritic happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant