Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running build.sh script #520

Closed
YerimB opened this issue Feb 23, 2024 · 1 comment
Closed

Error when running build.sh script #520

YerimB opened this issue Feb 23, 2024 · 1 comment

Comments

@YerimB
Copy link

YerimB commented Feb 23, 2024

  • Model: addw3
  • BIOS version: 2023-08-23_8173119
  • EC version: Never flashed
  • OS: Manjaro KDE
  • Kernel: 6.6.16-2-MANJARO

I'm getting an make error after some time when running ./scripts/build.sh addw3.

Steps to reproduce

I am on the branch master and followed the README.md instructions by running the following commands successively:

./scripts/install-deps.sh
source ~/.cargo/env
./scripts/build.sh addw3 # Error occurs here

Actual behavior

After some time of the command running I'm getting the following output:

'build/coreboot.rom' -> '/home/yem/Softwares/firmware-open/build/addw3/firmware.rom'
  CC        scratch/board/system76/common/scratch/../smfi.rel
  CC        scratch/board/system76/common/scratch/main.rel
  CC        scratch/board/system76/common/scratch/stdio.rel
  LINK      scratch/scratch.ihx
  OBJCOPY   scratch/scratch.rom
  XXD       include/scratch.h
  CC        flash/board/system76/common/flash/main.rel
  LINK      flash/flash.ihx
  OBJCOPY   flash/flash.rom
  XXD       include/flash.h
  CC        board/system76/common/main.rel
  CC        arch/8051/arch.rel
  ...
  CC        board/system76/common/pnp.rel
src/board/system76/addw3/gpio.c:37: error 283: function declarator with no prototype
  CC        board/system76/common/power.rel
  CC        board/system76/common/ps2.rel
  CC        board/system76/common/pwm.rel
  CC        board/system76/common/scratch.rel
  CC        board/system76/common/security.rel
make: *** [src/arch/8051/toolchain.mk:52: build/board/system76/addw3/gpio.rel] Error 1
make: *** Waiting for unfinished jobs....
  CC        board/system76/common/smbus.rel

Additional info

The only changes I made are in the submodule ec:

Modified ec/src/board/system76/addw3/board.mk: Updated the fan points (Double checked it).
Created ec/config.mk to try running make directly in ec/:

# cat ec/config.mk
BOARD?=system76/addw3
@crawfxrd
Copy link
Member

Already fixed in system76/ec#417.

You either need to use a newer EC commit or downgrade SDCC.

@YerimB YerimB closed this as completed Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants