Possible problem in the PI18 protocol library

[daniil226]

in the description of the protocol at the link:
https://github.com/jblance/mpp-solar/blob/master/docs/protocols/PI18_InfiniSolar-V-protocol-20170926.pdf

it is indicated that the request must be made

P005GS
and in the library at:

https://github.com/syssi/esphome-pipsolar/blob/pi18/components/pipsolar/pipsolar.h

a request is indicated everywhere P007GS

probably because of this, the library incorrectly sends the request or parses the received data.

I can't figure out how to fix it

here is part of the resulting log:
`[19:03:59][D][pipsolar:737]: Sending polling command : ^P007PIRI with length 9
[19:04:00][D][pipsolar:672]: checking crc on incoming message
[19:04:00][D][pipsolar:675]: CRC OK
[19:04:00][D][pipsolar:435]: Decode P007PIRI
[19:04:00][D][sensor:093]: 'pipsolar grid_rating_voltage': Sending state 220.00000 V with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar grid_rating_current': Sending state 22.70000 A with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar ac_output_rating_voltage': Sending state 220.00000 V with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar ac_output_rating_frequency': Sending state 50.00000 Hz with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar ac_output_rating_current': Sending state 22.70000 A with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar ac_output_rating_apparent_power': Sending state 5000.00000 VA with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar ac_output_rating_active_power': Sending state 5000.00000 W with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar battery_rating_voltage': Sending state 48.00000 V with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar battery_recharge_voltage': Sending state 47.00000 V with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar battery_redischarge_voltage': Sending state 54.00000 with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar battery_under_voltage': Sending state 46.00000 V with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar battery_bulk_voltage': Sending state 57.60000 V with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar battery_float_voltage': Sending state 57.50000 V with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar battery_type': Sending state 2.00000 with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar current_max_ac_charging_current': Sending state 30.00000 A with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar current_max_charging_current': Sending state 60.00000 A with 1 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar input_voltage_range': Sending state 1.00000 with 0 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar output_source_priority': Sending state 1.00000 with 0 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar charger_source_priority': Sending state 2.00000 with 0 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar parallel_max_num': Sending state 6.00000 with 0 decimals of accuracy
[19:04:00][D][sensor:093]: 'pipsolar machine_type': Sending state 0.00000 with 0 decimals of accuracy
[19:04:00][D][pipsolar:737]: Sending polling command : ^P007GS with length 7
[19:04:01][D][pipsolar:672]: checking crc on incoming message
[19:04:01][D][pipsolar:675]: CRC OK
[19:04:01][D][pipsolar:452]: Decode P007GS
[19:04:01][D][sensor:093]: 'pipsolar grid_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar grid_frequency': Sending state 0.00000 Hz with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar ac_output_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar ac_output_frequency': Sending state 0.00000 Hz with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar ac_output_apparent_power': Sending state 0.00000 VA with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar ac_output_active_power': Sending state 0.00000 W with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar output_load_percent': Sending state 0.00000 % with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar battery_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar battery_discharge_current': Sending state 0.00000 A with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar battery_charging_current': Sending state 0.00000 A with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar battery_capacity_percent': Sending state 0.00000 % with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar inverter_heat_sink_temperature': Sending state 0.00000 °C with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar pv1_input_power': Sending state 0.00000 W with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar pv2_input_power': Sending state 0.00000 W with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar pv1_input_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar pv2_input_voltage': Sending state 0.00000 V with 1 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar mppt1_charger_status': Sending state 0.00000 with 0 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar battery_power_direction': Sending state 0.00000 with 0 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar dc_ac_power_direction': Sending state 0.00000 with 0 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar line_power_direction': Sending state 0.00000 with 0 decimals of accuracy
[19:04:01][D][sensor:093]: 'pipsolar local_parallel_id': Sending state 0.00000 with 0 decimals of accuracy
[19:04:01][D][pipsolar:737]: Sending polling command : ^P005FWS with length 8
[19:04:02][D][pipsolar:672]: checking crc on incoming message
[19:04:02][D][pipsolar:675]: CRC OK
[19:04:02][D][pipsolar:488]: Decode P005FWS
[19:04:02][D][sensor:093]: 'pipsolar wfs fault_code': Sending state 0.00000 with 0 decimals of accuracy
[19:04:02][D][pipsolar:737]: Sending polling command : ^P005ET with length 7
[19:04:03][D][pipsolar:672]: checking crc on incoming message
[19:04:03][D][pipsolar:675]: CRC OK
[19:04:03][D][pipsolar:549]: Decode P005ET
[19:04:03][D][sensor:093]: 'pipsolar total_generated_energy': Sending state 7180157.00000 W with 0 decimals of accuracy
[19:04:03][D][pipsolar:737]: Sending polling command : ^P007PGS0 with length 9
[19:04:04][D][pipsolar:672]: checking crc on incoming message

`

[daniil226]

help how to correct the sent command?

here is part of the resulting expanded log:
`
[21:24:36][D][pipsolar:737]: Sending polling command : ^P007PGS0 with length 9
[21:24:37][D][uart_debug:158]: <<< "^D1091,5,00,2280,500,2280,500,0524,0498,00524,00498,010,009,502,006,000,000,040,0000,0000,0550,0014,2,0,1,2,2,1%\v\r"

[21:24:38][D][pipsolar:737]: Sending polling command : ^P007PIRI with length 9
[21:24:39][D][uart_debug:158]: <<< "^D0882200,227,2200,500,227,5000,5000,480,470,540,460,576,575,2,30,060,1,1,2,6,0,0,0,1,2,01\xE7F\r"

[21:24:39][D][pipsolar:737]: Sending polling command : ^P007GS with length 7
[21:24:39][D][uart_debug:158]: <<< "^0\e\xE3\r"

`

[daniil226]

I found branches that meet the protocol, sorry for the stupid question

[syssi]

No problem. This project and project structure is pretty hard to learn and lacks of any documentation :-)

[daniil226]

sorry for my stupid questions