Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct annotated layout for model BIOMD0000000872 #49

Open
luciansmith opened this issue Apr 29, 2021 · 4 comments
Open

Correct annotated layout for model BIOMD0000000872 #49

luciansmith opened this issue Apr 29, 2021 · 4 comments

Comments

@luciansmith
Copy link
Contributor

Because the existing layout was invalid for the reactions, I just copied the list of reaction layouts from verma2017.xml into MODEL1605030001_url.xml

This results in a valid model; however, I haven't tried to actually look at the resulting layout to see if it makes sense, if the reactions in question actually exist, etc. This shouldn't take long (with the right tools), but needs to be checked.

@jonrkarr
Copy link
Collaborator

jonrkarr commented Feb 6, 2022

@luciansmith's suggestion to manually review this is good.

Alternatively, here's a simpler path toward valid, albeit less useful SBML:

  • Remove the layout from this model (from manual-fixes subdirectory)
  • Commit the changes to this repository

@jonrkarr jonrkarr changed the title Curate layout in model 872 Curate layout in model BIOMD0000000872 Feb 6, 2022
@jonrkarr jonrkarr changed the title Curate layout in model BIOMD0000000872 Correct annotated layout for model BIOMD0000000872 Feb 6, 2022
@freiburgermsu
Copy link
Collaborator

@jonrkarr Do you mean removing this tag <layout:listOfLayouts xmlns:layout="http://www.sbml.org/sbml/level3/version1/layout/version1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> from the verma2017.xml? It constitutes ~1/4 of the file.

@jonrkarr
Copy link
Collaborator

Yes, this was my suggestion. @luciansmith is that fine with you?

@luciansmith
Copy link
Contributor Author

I still think we should look at the layout to see if it makes sense. The file is already valid; we don't have to do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants