Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexporter enhancements #1402

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Flexporter enhancements #1402

merged 1 commit into from
Dec 22, 2023

Conversation

dehall
Copy link
Contributor

@dehall dehall commented Dec 7, 2023

This PR adds a few enhancements identified when trying to create "Not Done" type resources for QICore. (Ex, Medication Not Requested https://build.fhir.org/ig/HL7/fhir-qi-core/StructureDefinition-qicore-medicationnotrequested.html )

  • Disables the annoying warning the flexporter introduced. For a single patient it wasn't that big a deal but for larger populations it made it impossible to follow the output.
  • Adds a "fullUrl" field to the Bundle entry on any created resources
  • When creating resources based on a given state, adds the ability to reference the Encounter that was active at that time
  • Adds a specific "No Aspirin" state to the ACS Discharge Meds submodule for the flexporter to key off of for this example. We may want to make it a "best practice" to have an actual empty simple-type state in modules when a treatment option is skipped, to make it easier to identify.
  • Adds a flexporter mapping in src/test/resources with a new Not Done example. Try running it with ./run_synthea -fm src/test/resources/flexporter/qicore_withnotdone.yaml -k must_have_cardiac_surgery.json -a 55-65

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (85673df) 76% compared to head (8ded418) 77%.

Files Patch % Lines
...a/org/mitre/synthea/export/flexporter/Actions.java 25% 23 Missing and 4 partials ⚠️
src/main/java/App.java 0% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #1402    +/-   ##
=========================================
  Coverage        76%     77%            
- Complexity     3850    3875    +25     
=========================================
  Files           178     178            
  Lines         24997   25034    +37     
  Branches       3535    3546    +11     
=========================================
+ Hits          19136   19277   +141     
+ Misses         4735    4641    -94     
+ Partials       1126    1116    -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eedrummer eedrummer merged commit 16ee9bc into master Dec 22, 2023
6 of 8 checks passed
@eedrummer eedrummer deleted the flexporter_qicorenotdone branch December 22, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants