-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module cleanup #1399
Module cleanup #1399
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1399 +/- ##
=========================================
Coverage 76% 77%
- Complexity 3843 3875 +32
=========================================
Files 178 178
Lines 24997 24997
Branches 3535 3535
=========================================
+ Hits 19150 19273 +123
+ Misses 4713 4608 -105
+ Partials 1134 1116 -18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly these changes look fine, except for the home health and snf changes.
Not sure why you removed the reason
-- we sort of need that for the claims exporting that we're doing. It would be better to end the condition at discharge than to delete the reason.
I don't really want to get rid of the reasons on anything, but "Transition from acute care to home-health care (finding)" and "Patient transfer to skilled nursing facility (procedure)" really don't feel like they should be Conditions, and we don't have anything else that can be set as a reason. |
Then later, we could modify the modules put the patient into SNF/home care to set that attribute.... which would be a better long term solution, and setting the attribute only-if-nil would be a backup. |
Just pushed some updates to bring back the Home health was only invoked by 2 other modules, Total Joint Replacement and Home Hospice. TJR was easy to add the appropriate codes to for the "reason", but in the Home Hospice module, there are ~40 different possible conditions the patient might have so I skipped that. For SNF, there are a bunch of instances in the Injuries module and that same group of 40 conditions from the Home Hospice module, so I didn't add any more specific reasons. If you think it's worthwhile I can add the codes for the respective Injuries module branches that call the SNF submodule. |
This PR cleans up a few items that pop up pretty often in generated records and look odd: