Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events_to_raster should provide option to not shift timestamp of first event to 0 #188

Open
ssinhaleite opened this issue Dec 5, 2023 · 1 comment
Assignees
Labels
doing Work in Progress

Comments

@ssinhaleite
Copy link
Contributor

Currently, when converting a list of events to a raster, using ChipFactory.events_to_raster, the timestamps will be aligned automatically such that the time of the first event is 0. This can be useful when the timestamps start with a high value and we only care about the timings after the first event.

However, often the timestamper is reset before recording events and hence the time of the first event can be of interested. I suggest providing the option of not aligning timestamps, in order to preserve this information.

@bauerfe bauerfe self-assigned this Jan 26, 2024
@bauerfe bauerfe added the doing Work in Progress label Jan 26, 2024
@bauerfe
Copy link
Contributor

bauerfe commented Jan 26, 2024

Implementation done, but still needs unit testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doing Work in Progress
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants