Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to fail the build #77

Open
cse050 opened this issue Sep 30, 2024 · 1 comment
Open

Allow to fail the build #77

cse050 opened this issue Sep 30, 2024 · 1 comment

Comments

@cse050
Copy link

cse050 commented Sep 30, 2024

Today, the action reports the result of the "validation" in the output of the pipeline, and it raises/publishes the results to the "portal".

But, in the GitHub Actions pipeline, then it just "succeeds" even if "issues are found".

I.e. we cannot use the action, as is, to protect our pipelines, i.e. to the break the build, if any "violations" are found.

It would be useful with an option, where the plugin fails the build, if any "violations" are found, even for non PR builds.

I mean, it could be that a "security concern" has been registered/discovered, after the original PR were raised and approved. We want the plugin to be able to protect our pipelines in these scenarios as well, e.g. on deployments, so a deployment cannot take place, if contains "violations" that we discovered after the original PR.

@levitin
Copy link

levitin commented Nov 5, 2024

Does this issue occur only if you set scan-mode: INTELLIGENT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants