Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo compatibility #218

Open
josefelbez opened this issue Feb 29, 2024 · 2 comments
Open

Expo compatibility #218

josefelbez opened this issue Feb 29, 2024 · 2 comments

Comments

@josefelbez
Copy link

josefelbez commented Feb 29, 2024

Considering Expo's expanding presence, integrating React Native LDK seamlessly into the Expo workflow seems like a good move, but we currently find two main issues:

  • The Logger class, located in lib/ios/Classes/LdkLogger.swift, causes build failures when using EAS BUILD.
  • Integration with Android requires manual steps, such as adding LDK to android/app/build.gradle. A potential solution could involve creating an Expo custom plugin, allowing developers to simply add the plugin to app.json for seamless integration without the need to modify any native code. This approach aligns with Expo's philosophy and would streamline the process for developers. Reference: Expo Config Plugins.

As for the first issue I already submitted a pr that fixes it and needs to be reviewed, for the second review is a little more complicated so I wanted to ask if that's in your interest and could potentially be merged after reviewed as well, if yes i could assign it to myself and do a pr as well.

PS: I'm talking about EXPO dev client here and not EXPO Go.

@Jasonvdb
Copy link
Collaborator

Jasonvdb commented Mar 4, 2024

Thanks! On your first point, merged here.
Regarding the expo plugin, we're not using expo ourselves and so this won't likely be a priority for our dev team over features and bug fixes. But PR's for this are welcome! Provided the lib is still 100% compatible with regular RN projects.

@josefelbez
Copy link
Author

Thanks for your answer, yes it will still be 100% compatible with RN projects, but at the same way easier to use with expo, soon I'll open a pr. Maybe this will help new devs that have the expo environment to use the react-native-ldk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants